Use 0.11.0 upstream theia before fixing breaking changes in upstream master #451
Conversation
…master Change-Id: I05b6ff8d876a09b2014829b7213389a12c89ca31 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
AndrienkoAleksandr,
evidolob,
l0rd,
mmorhun,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
| "@eclipse-che/theia-plugin-ext": "^0.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "rimraf": "latest", | ||
| "typescript": "latest" | ||
| "typescript": "3.1.3" |
There was a problem hiding this comment.
@benoitf could you please explain why do we need to fix typescript version here?
There was a problem hiding this comment.
@mmorhun because it's tagged everywhere else. I think it's a mistake to have latest there
There was a problem hiding this comment.
Thanks for explanation. Now it is clear. (I was trying to find connection with switching versions)
There was a problem hiding this comment.
https://github.com/eclipse/che-theia/blob/master/package.json#L13
yes, it was done on purpose. I had invalid typescript dependencies.
we could cleanup later dependencies as it seems a lot of dependencies are in main package.json
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com> Co-authored-by: Vitalii Parfonov <vparfono@redhat.com>
What does this PR do?
Use theia 0.11.0 before fixing code due to upstream changes
What issues does this PR fix or reference?
eclipse-theia/theia#6252