This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
allow slashes in ORGANIZATION field by using... #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
requested review from
benoitf,
evidolob,
l0rd,
rhopp and
vparfonov
as code owners
|
Can one of the admins verify this patch? |
|
Related to #470 -- need this change to allow the ORGANIZATION field to include both the registry and the organization. Eventually Theia will be publishing builds to quay.io, not docker.io, right? So we'll need this. :) |
…tead of / Change-Id: I69d8d6c6c3c21531e29deaf68e95a8bd7dad14b7 Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
allow-slashes-in-ORGANIZATION
branch
from
cd0e311 to
380c128
Compare
benoitf
approved these changes
Oct 6, 2019
|
ci-build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow slashes in ORGANIZATION field by using @ for sed separators instead of /
Related to eclipse-che/che#13765
Change-Id: I69d8d6c6c3c21531e29deaf68e95a8bd7dad14b7
Signed-off-by: nickboldt nboldt@redhat.com