Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix resize failed errors in the browser console #530

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 3, 2019

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

It prevents 'resize' failed errors after creating a new terminal.

What issues does this PR fix or reference?

eclipse-che/che#13830

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 3, 2019

✅ E2E Happy path tests succeed 🎉

Try it

See Details

name link
che-theia docker.io/maxura/che-theia:530
che-remote-plugin-node docker.io/maxura/che-remote-plugin-node:530
che-remote-plugin-runner-java8 docker.io/maxura/che-remote-plugin-runner-java8:530
che-remote-plugin-kubernetes-tooling-1.0.0 docker.io/maxura/che-remote-plugin-kubernetes-tooling-1.0.0:530

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't reproduce the error with PR

@olexii4 olexii4 merged commit a3302d1 into master Nov 4, 2019
@olexii4 olexii4 deleted the CHE-13830 branch November 4, 2019 19:12
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants