Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Do not use webview service for product logo in about dialog #555

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Nov 19, 2019

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

In About dialog we used webview API implementation endpoint to retrieve product logo. Such approach is not good and current PR retrieves the logo via upstream mini-browser service.

What issues does this PR fix or reference?

eclipse-che/che#14883

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 19, 2019

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:555
che-remote-plugin-node docker.io/maxura/che-remote-plugin-node:555
che-remote-plugin-runner-java8 docker.io/maxura/che-remote-plugin-runner-java8:555
che-remote-plugin-kubernetes-tooling-1.0.0 docker.io/maxura/che-remote-plugin-kubernetes-tooling-1.0.0:555

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@mmorhun mmorhun merged commit ed73944 into master Nov 20, 2019
@mmorhun mmorhun deleted the CHE-14883 branch November 20, 2019 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants