This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Use correct binary for packaging plugin into zip container #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
requested review from
l0rd,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
benoitf
approved these changes
Jan 8, 2020
azatsarynnyy
approved these changes
Jan 8, 2020
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Lining Pan <lining_pan@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal fix build of che-theia after upgrade yarn to version 1.19.1
The problem was occurred when user upgrades yarn to version 1.19.1. Plugins are using
@theia/plugin-packageras a dependency to pack themselves to zip container. On 1.19.0 there isn't any problem, because@theia/plugin-packagerdependency providestheia:pluginandtheia-pluginbinaries. But on 1.19.1 there is onlytheia-pluginbinary.Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
eclipse-che/che#15552
Release Notes
N/A
Docs PR
N/A