-
Notifications
You must be signed in to change notification settings - Fork 111
Devfile for che-theia dogfooding on che.openshift.io #627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be interesting to add a badge to try that from README or contribute ?
Can one of the admins verify this patch? |
@benoitf thanks for fixes |
URI to the devfile will be changed from to (osio-devfile -> master) before merging this PR |
@@ -0,0 +1,117 @@ | |||
# Copyright (c) 2020 Red Hat, Inc. | |||
# This program and the accompanying materials are made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitaliy-guliy looks good, just a note that osio
is sorta deprecated name consider using hosted-che
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried the described flow - works well. 👍
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR:
- the PR allows to develop
theia
and get/test the changes on the second instance - it would be nice to have some
Rsync che-theia
command to allow doing changes forche-theia
project and test the changes on the second instance - unfortunately
che-theia
plugins are not started for me
I believe the problem related to starting of che-theia
plugins will be fixed soon when che.openshift.io is updated to the next version.
About adding Rsync che-theia
command - we can do it as improvement in a separate PR.
Good job, @vitaliy-guliy, it's good start for dogfooding on che.openshift.io, thank you very much!
E2E tests of Eclipse Che Multiuser on OCP has failed: |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
crw-ci-test |
1 similar comment
crw-ci-test |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
crw-ci-test |
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
c97a81a
to
8c48b9e
Compare
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
crw-ci-test |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
Build finished, happy path tests are failing due to known reason eclipse-che/che#16403 |
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Devfile to develop che-theia on che.openshift.io
Considering to the disk space limitation for /projects directory, it's only possible to build che-theia inside /tmp directory, which has 3GB.
Sources are persisted in /projects directory, but copied and then built in /tmp/theia.
The devfile has commands to
What issues does this PR fix or reference?
No issue