This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Align 'configStorage' object to theia changes #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
|
crw-ci-test |
RomanNikitenko
requested review from
azatsarynnyy,
benoitf and
vzhukovs
as code owners
azatsarynnyy
approved these changes
Feb 26, 2020
|
crw-ci-test |
vzhukovs
approved these changes
Feb 26, 2020
benoitf
approved these changes
Feb 26, 2020
|
@RomanNikitenko fixed issue is eclipse-che/che#16149 correct ? |
|
@benoitf |
|
crw-ci-test |
|
as build check is passing, I would merge it ? |
|
crw-ci-test |
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
vinokurig
added a commit
that referenced
this pull request
Apr 6, 2021
* Update the vscode GitHub Pull Request plugin Signed-off-by: Igor Vinokur <ivinokur@redhat.com> * fixup! golang sidecar gopls fix (#638) * fixup! Update the vscode GitHub Pull Request plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Align 'configStorage' object to theia changes
What issues does this PR fix or reference?
eclipse-che/che#16149
Signed-off-by: Roman Nikitenko rnikiten@redhat.com