Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add oAuth plugin API methods #665

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Add oAuth plugin API methods #665

merged 3 commits into from
Mar 16, 2020

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Add getProviders() and isAuthenticated() oAuth methods to plugin API.

What issues does this PR fix or reference?

eclipse-che/che#15261

Release Notes

Docs PR

@vinokurig
Add oAuth plugin API methods
78a8694 
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:665
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:665

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Mar 13, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:665
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:665

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@vinokurig
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:665
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:665

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@vinokurig
Copy link
Contributor Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:665
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:665

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

dmytro-ndp
dmytro-ndp reviewed Mar 16, 2020
View reviewed changes
extensions/eclipse-che-theia-plugin-ext/src/node/che-api-service.ts
async getOAuthProviders(): Promise<string[]> {
const cheApiClient = await this.getCheApiClient();
try {
return await cheApiClient.getOAuthProviders();
Copy link
Contributor

@dmytro-ndp dmytro-ndp Mar 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR check fails here because of error:

task-plugin: $ rimraf lib
@eclipse-che/theia-plugin-ext: [compile] src/node/che-api-service.ts(301,39): error TS2339: Property 'getOAuthProviders' does not exist on type 'IRemoteAPI'.

@che-bot
Copy link
Contributor

che-bot commented Mar 16, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:665
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:665

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@vinokurig vinokurig merged commit a9e8347 into master Mar 16, 2020
@vinokurig vinokurig deleted the che-15261 branch March 16, 2020 13:50
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@ericwill
Fix width of automatic plugin report (#665)
c3e19b7 
* Fix width of automatic plugin report

Currently the automatic plugin report looks very scrunched. This change will allow the table to take up the width of the page.

Signed-off-by: Eric Williams <ericwill@redhat.com>

* Use palette.styl

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp left review comments

@benoitf benoitf benoitf approved these changes

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko

@vzhukovs vzhukovs Awaiting requested review from vzhukovs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinokurig @che-bot @benoitf @dmytro-ndp