This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
force-pushed
the
improveRunningTask
branch
from
May 14, 2020 13:17
4a2985d
to
6d93698
Compare
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
RomanNikitenko
requested review from
azatsarynnyy,
benoitf,
ericwill,
svor,
tsmaeder,
vinokurig,
vitaliy-guliy and
vzhukovs
as code owners
May 14, 2020 13:59
Theia |
RomanNikitenko
force-pushed
the
improveRunningTask
branch
from
May 18, 2020 07:09
6d93698
to
99bf85c
Compare
crw-ci-test |
crw-ci-test |
crw-ci-test |
azatsarynnyy
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving it based on the demo I saw.
Great investigation and nice improvements! 👍
RomanNikitenko
force-pushed
the
improveRunningTask
branch
from
May 18, 2020 12:23
99bf85c
to
409eac7
Compare
crw-ci-test |
AndrienkoAleksandr
approved these changes
May 18, 2020
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
improveRunningTask
branch
from
May 19, 2020 13:06
409eac7
to
11debec
Compare
crw-ci-test |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
[ci-build] |
vzhukovs
approved these changes
May 19, 2020
This was referenced May 19, 2020
benoitf
added
the
new¬eworthy
For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
label
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
kind/enhancement
New feature or request
new¬eworthy
For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR depends on upstream changes.
What does this PR do?
remote
terminal widget forche
tasks as well as forche
terminalsche
taskvs code
/theia
taskRun Last Task
action forche
tasksAttach Task
action forche
tasksWhat issues does this PR fix or reference?
How to test?
You can use the following devfile to test the changes or take only
cheEditor
component from my devfile and include it in your devfile.Devfile
che
,vs code
/theia
) fromTerminal
--->Run Task
menuworkingDir
andcommand
fieldsTry to play with
component
fieldTry to use
Run Last Task
andAttach Task
actions