Pin to upstream Theia commit as adaptation is required

[azatsarynnyy]

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Stabilizes Che Theia build and fixes critical runtime issues by:

• switching to upstream Theia commit as an adaptation to the latest changes is required - SemanticTokens Plug-in API
• switching to the previous version of @eclipse-che/workspace-client as the latest one brings breaking changes

Screenshot/screencast of this PR

What issues does this PR fix or reference?

closes eclipse-che/che#18255 and fixes partially eclipse-che/che#18278

How to test this PR?

1. Use How to test button, provided by @che-bot, to spin-up the Workspace.
2. Check that the plug-ins are loaded.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job console

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:901
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:901

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[benoitf]

should we change HAPPY_PATH_CHANNEL ?

[dmytro-ndp]

@benoitf there are no changes in Happy Path tests since 7.21.0 release.

[vinokurig]

Checking out to an earlier commit solves the build failure but plugins fail to load.

[azatsarynnyy]

[crw-ci-test]

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job console

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:901
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:901

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[monaka]

@azatsarynnyy It disables the patch in eclipse-che/che-workspace-client#42 by this PR.
Che-theia won't work fine in some deployment patterns.

How about this step to fix?

In che-workspace-plugin:

1. Creates a new branch prepare-v0.1.0 from the master branch.
2. Reverts Align workspace-client with changes in REST API che-workspace-client#39 in the master branch temporally.

In che-theia:

1. Uses @eclipse-che/workspace-client:latest again.

[benoitf]

@monaka this is temporary, there is an ongoing patch on workspace-client library
So it will goes back to latest everywhere

[monaka]

I see. I'll manage my environment by some workarounds until the code stable.

[azatsarynnyy]

Hi @monaka
Thank you for the suggestions! 👍

Reverts eclipse-che/che-workspace-client#39 in the master branch temporally

I'm not sure it's a good idea as there are other downstream projects are relying on this lib, e.g. Che Dashboard

As @benoitf has already mentioned, we're waiting for a review on eclipse-che/che-workspace-client#44 from the project maintainers. And then we'll decide whether we are merging eclipse-che/che-workspace-client#44 and upgrading Che Theia to the latest one, OR we're applying the workaround proposed in #904

[azatsarynnyy]

@monaka FYI: Che Theia now depends on @eclipse-che/workspace-client:latest #911