This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Don't remove test.js files after executing che-theia production #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svor <vsvydenk@redhat.com>
svor
requested review from
azatsarynnyy,
RomanNikitenko and
vzhukovs
as code owners
Signed-off-by: svor <vsvydenk@redhat.com>
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
benoitf
approved these changes
Nov 16, 2020
|
[crw-ci-test] |
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
azatsarynnyy
approved these changes
Nov 16, 2020
|
[crw-ci-test] |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: svor vsvydenk@redhat.com
What does this PR do?
Some libraries like shelljs can provide test.js file as a source file and which is needed for the library to work correctly. This PR provides changes to don't remove test.js files after generating che-theia in production mode by using che-theia generator.
What issues does this PR fix or reference?
It is needed for eclipse-che/che#17205 because @kubernetes/client-node depends on shelljs
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable