Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Authorize GitHub requests with header instead of query parameter #939

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Nov 27, 2020

What does this PR do?

Backport #924

Use GitHub Authorisation header in GitHub HTTP requests instead of token in query parameter.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#16425

How to test this PR?

  1. Setup GitHub Identity provider
  2. Start a workspace with GitHub Pull Requests plugin and a project cloned from GitHub by https url.
    You can use this devfile to start a workspace:
apiVersion: 1.0.0
metadata:
  name: wksp-custom-dwdiu
projects:
  - name: che-theia
    source:
      location: 'https://github.com/eclipse/che-theia.git'
      type: git
      branch: master
components:
  - type: chePlugin
    reference: 'https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/ms-vscode/vscode-github-pullrequest/0.20.0/meta.yaml'
  - type: cheEditor
    reference: 'https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-939/simple/che-theia-editor.yaml'
  1. Sign-in to the GitHub Pull Requests plugin.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backporting LGTM

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as it's a backport from the master branch.

@vinokurig vinokurig merged commit aa4f001 into 7.20.x Nov 27, 2020
@vinokurig vinokurig deleted the 7.20.x_backport branch November 27, 2020 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants