Updated method names to better reflect their actions

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
eclipse-che · Mar 29, 2023 · 0ce844c · 0ce844c
1 parent 6b20457
commit 0ce844c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/tests/e2e/pageobjects/dashboard/CreateWorkspace.ts b/tests/e2e/pageobjects/dashboard/CreateWorkspace.ts
@@ -52,12 +52,6 @@ export class CreateWorkspace {
         await this.driverHelper.waitAndClick(sampleLocator, timeout);
     }
 
-    async startWorkspaceUsingFactory(factoryUrl: string, timeout: number = TimeoutConstants.TS_CLICK_DASHBOARD_ITEM_TIMEOUT): Promise<void> {
-        Logger.debug(`CreateWorkspace.startWorkspaceUsingFactory factoryUrl: "${factoryUrl}"`);
-        await this.driverHelper.waitVisibility(CreateWorkspace.FACTORY_URL_LOCATOR, timeout);
-        await this.driverHelper.type(CreateWorkspace.FACTORY_URL_LOCATOR, Key.chord(factoryUrl, Key.ENTER), timeout);
-    }
-
     async clickOnSampleForSpecificEditor(sampleName: string, timeout: number = TimeoutConstants.TS_CLICK_DASHBOARD_ITEM_TIMEOUT): Promise<void> {
         await this.clickOnEditorsDropdownListButton(sampleName, timeout);
 
@@ -67,6 +61,12 @@ export class CreateWorkspace {
         await this.driverHelper.waitAndClick(sampleLocator, timeout);
     }
 
+    async importFromGitUsingUI(factoryUrl: string, timeout: number = TimeoutConstants.TS_CLICK_DASHBOARD_ITEM_TIMEOUT): Promise<void> {
+        Logger.debug(`CreateWorkspace.importFromGitUsingUI factoryUrl: "${factoryUrl}"`);
+        await this.driverHelper.waitVisibility(CreateWorkspace.FACTORY_URL_LOCATOR, timeout);
+        await this.driverHelper.type(CreateWorkspace.FACTORY_URL_LOCATOR, Key.chord(factoryUrl, Key.ENTER), timeout);
+    }
+
     private async clickOnEditorsDropdownListButton(sampleName: string, timeout: number): Promise<void> {
         Logger.debug(`CreateWorkspace.clickOnSample sampleName: "${sampleName}, editor ${TestConstants.TS_SELENIUM_EDITOR}"`);
 

diff --git a/tests/e2e/specs/devfiles/SmokeTest.spec.ts b/tests/e2e/specs/devfiles/SmokeTest.spec.ts
@@ -22,11 +22,11 @@ const projectAndFileTests: ProjectAndFileTests = e2eContainer.get(CLASSES.Projec
 const workspaceHandlingTests: WorkspaceHandlingTests = e2eContainer.get(CLASSES.WorkspaceHandlingTests);
 const loginTests: LoginTests = e2eContainer.get(CLASSES.LoginTests);
 
-suite(`The ${factoryUrl} userstory`, async function () {
+suite(`The SmokeTest userstory`, async function () {
     let projectSection: ViewSection;
     suite(`Create workspace from factory:${factoryUrl}`, async function () {
         loginTests.loginIntoChe();
-        workspaceHandlingTests.createAndOpenWorkspaceFromFactory(factoryUrl);
+        workspaceHandlingTests.createAndOpenWorkspaceFromGitRepository(factoryUrl);
         workspaceHandlingTests.obtainWorkspaceNameFromStartingPage();
         test('Register running workspace', async () => {
             registerRunningWorkspace(WorkspaceHandlingTests.getWorkspaceName());

diff --git a/tests/e2e/tests-library/WorkspaceHandlingTests.ts b/tests/e2e/tests-library/WorkspaceHandlingTests.ts
@@ -66,15 +66,15 @@ export class WorkspaceHandlingTests {
         });
     }
 
-    public createAndOpenWorkspaceFromFactory(factoryUrl: string): void {
+    public createAndOpenWorkspaceFromGitRepository(factoryUrl: string): void {
         test(`Create and open new workspace from factory:${factoryUrl}`, async () => {
             await this.dashboard.waitPage();
             Logger.debug(`Fetching user kubernetes namespace, storing auth token by getting workspaces API URL.`);
             await this.apiUrlResolver.getWorkspacesApiUrl();
             await this.dashboard.clickCreateWorkspaceButton();
             await this.createWorkspace.waitPage();
             WorkspaceHandlingTests.parentGUID = await this.browserTabsUtil.getCurrentWindowHandle();
-            await this.createWorkspace.startWorkspaceUsingFactory(factoryUrl);
+            await this.createWorkspace.importFromGitUsingUI(factoryUrl);
             await this.browserTabsUtil.waitAndSwitchToAnotherWindow(WorkspaceHandlingTests.parentGUID, TimeoutConstants.TS_IDE_LOAD_TIMEOUT);
         });
     }