Skip to content

Commit

Permalink
Remove outdated workaround to che#14520
Browse files Browse the repository at this point in the history
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
  • Loading branch information
dmytro-ndp committed Jun 5, 2021
1 parent ceceb72 commit 34dd102
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 18 deletions.
2 changes: 1 addition & 1 deletion tests/e2e/pageobjects/ide/TopMenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class TopMenu {
const submenuItemLocator: By = this.getSubmenuItemLocator(itemText);

// to ensure that drop-down animation is over
await this.driverHelper.wait(3000);
await this.driverHelper.wait(timeout);

await this.driverHelper.waitAndClick(submenuItemLocator, timeout);
}
Expand Down
19 changes: 2 additions & 17 deletions tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { DebugView } from '../../pageobjects/ide/DebugView';
import { DialogWindow } from '../../pageobjects/ide/DialogWindow';
import { Terminal } from '../../pageobjects/ide/Terminal';
import * as fs from 'fs';
import { ContextMenu } from '../../pageobjects/ide/ContextMenu';
import { Workspaces } from '../../pageobjects/dashboard/Workspaces';
import { Dashboard } from '../../pageobjects/dashboard/Dashboard';
import { TimeoutConstants } from '../../TimeoutConstants';
Expand All @@ -37,7 +36,6 @@ const ide: Ide = e2eContainer.get(CLASSES.Ide);
const projectTree: ProjectTree = e2eContainer.get(CLASSES.ProjectTree);
const topMenu: TopMenu = e2eContainer.get(CLASSES.TopMenu);
const editor: Editor = e2eContainer.get(CLASSES.Editor);
const contextMenu: ContextMenu = e2eContainer.get(CLASSES.ContextMenu);
const previewWidget: PreviewWidget = e2eContainer.get(CLASSES.PreviewWidget);
const workspaces: Workspaces = e2eContainer.get(CLASSES.Workspaces);
const rightToolBar: RightToolBar = e2eContainer.get(CLASSES.RightToolBar);
Expand Down Expand Up @@ -135,15 +133,8 @@ suite('Language server validation', async () => {

test('Codenavigation', async () => {
await editor.moveCursorToLineAndChar(javaFileName, 32, 17);
try {
await editor.performKeyCombination(javaFileName, Key.chord(Key.CONTROL, Key.F12));
await editor.waitEditorAvailable(codeNavigationClassName);
} catch (err) {
// workaround for issue: https://github.com/eclipse/che/issues/14520
if (err instanceof error.TimeoutError) {
checkCodeNavigationWithContextMenu();
}
}
await editor.performKeyCombination(javaFileName, Key.chord(Key.CONTROL, Key.F12));
await editor.waitEditorAvailable(codeNavigationClassName);
});

test.skip('Yaml LS initialization', async () => {
Expand Down Expand Up @@ -295,12 +286,6 @@ async function checkErrorMessageInApplicationController() {
await ide.waitAndSwitchToIdeFrame();
}

async function checkCodeNavigationWithContextMenu() {
await contextMenu.invokeContextMenuOnActiveElementWithKeys();
await contextMenu.waitContextMenuAndClickOnItem('Go to Definition');
console.log('Known isuue https://github.com/eclipse/che/issues/14520.');
}

async function checkJavaPathCompletion() {
if (await ide.isNotificationPresent('Classpath is incomplete. Only syntax errors will be reported')) {
const classpathText: string = fs.readFileSync('./files/happy-path/petclinic-classpath.txt', 'utf8');
Expand Down

0 comments on commit 34dd102

Please sign in to comment.