[TS SELENIUM] Fix the #13865 issue (Happy Path test is sometimes fail…

…ing on "Error highlighting" step) (#13987)
eclipse-che · Jul 24, 2019 · a35bd99 · a35bd99
1 parent e598e22
commit a35bd99
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/e2e/pageobjects/ide/Ide.ts b/e2e/pageobjects/ide/Ide.ts
@@ -182,13 +182,16 @@ export class Ide {
         for (let i = 1; i <= notificationsCapacity; i++) {
             const notificationLocator: By = By.xpath('//div[@class=\'theia-Notification\']//button[text()=\'Close\']');
 
-            const isElementVisible: boolean = await this.driverHelper.isVisible(notificationLocator);
+            try {
+                await this.driverHelper.waitAndClick(notificationLocator);
+            } catch (err) {
+                if (err instanceof error.TimeoutError) {
+                    console.log(`The '${notificationLocator}' element is not visible and can't be clicked`);
+                    continue;
+                }
 
-            if (!isElementVisible) {
-                continue;
+                throw err;
             }
-
-            await this.driverHelper.waitAndClick(notificationLocator);
         }
     }
 

diff --git a/e2e/tests/e2e_happy_path/HappyPath.spec.ts b/e2e/tests/e2e_happy_path/HappyPath.spec.ts
@@ -118,9 +118,9 @@ suite('Language server validation', async () => {
     });
 
     test('Error highlighting', async () => {
-        await editor.type(javaFileName, 'textForErrorHighlighting', 30);
+        await editor.type(javaFileName, 'error', 30);
         await editor.waitErrorInLine(30);
-        await editor.performKeyCombination(javaFileName, Key.chord(Key.CONTROL, 'z'));
+        await editor.performKeyCombination(javaFileName, Key.chord(Key.BACK_SPACE, Key.BACK_SPACE, Key.BACK_SPACE, Key.BACK_SPACE, Key.BACK_SPACE));
         await editor.waitErrorInLineDisappearance(30);
     });