Store github token in session storage, remove on logout

Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
eclipse-che · Jul 23, 2019 · f6b7d35 · f6b7d35
1 parent 05117f9
commit f6b7d35
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/dashboard/src/components/api/che-keycloak.factory.ts b/dashboard/src/components/api/che-keycloak.factory.ts
@@ -68,7 +68,8 @@ export class CheKeycloak {
   }
 
   logout(): void {
-	window.sessionStorage.setItem('oidcDashboardRedirectUrl', location.href);
+    window.sessionStorage.removeItem('githubToken');
+    window.sessionStorage.setItem('oidcDashboardRedirectUrl', location.href);
     this.keycloak.logout({});
   }
 

diff --git a/dashboard/src/components/github/github-service.ts b/dashboard/src/components/github/github-service.ts
@@ -124,10 +124,10 @@ export class GitHubService {
       .factory('gitHubTokenStore', function () {
         return {
           setToken: function (token: string) {
-            localStorage.setItem('gitHubToken', token); // jshint ignore:line
+            sessionStorage.githubToken = token;
           },
           getToken: function () {
-            return localStorage.getItem('gitHubToken'); // jshint ignore:line
+            return sessionStorage.githubToken;
           }
         };
       }).factory('gitHubApiUtils', ['gitHubApiUrlRoot', function (gitHubApiUrlRoot: string) {