Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sidecars memory into total memory of workspace on dashboard #11801

Closed
mmorhun opened this issue Nov 1, 2018 · 11 comments
Closed

Include sidecars memory into total memory of workspace on dashboard #11801

mmorhun opened this issue Nov 1, 2018 · 11 comments
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Nov 1, 2018

Description

When a Che 7 workspace is created, dashboard shows RAM consuming only for added by user machines and doesn't include sidecars (IDEs, plugins) in total sum. In such case dashboard shows needed RAM for workspace not correctly.
More specific example: user's container needs 1Gb of RAM (and this is shown), but actual consuming is, for example, 3Gb (2Gb is needed for sidecars).

Reproduction Steps

Create Che 7 workspace, add IDE and plugin(s). Dashboard shows memory only for user defined machine(s).

@garagatyi garagatyi added team/platform kind/task Internal things, technical debt, and to-do tasks to be performed. labels Nov 1, 2018
@l0rd
Copy link
Contributor

l0rd commented Dec 19, 2018

The memory-limit attribute of an editor/plugin is currently defined in the che_pluing.yaml. Currently the dashboard doesn't have access to that attribute.

The possible solution that comes to mind is to add the memory-limit field in the plugin registry meta.yaml files. If not set the dashboard will override it to a default of 300MB.

To overwrite the memory setting the dashboard should set the following attribute in the workspace config json:

"sidecar.<plugin-id>.memory_limit": "300Mi"

@garagatyi
Copy link

It is also possible that che-plugin.yaml doesn't contain memory limit field. Then Che master would use its default value.
Another case is when Che master adds some additional sidecars, e.g. jwt-proxy sidecar. It is not shown anywhere in the workspace config that this sidecar will be added.

@benoitf
Copy link
Contributor

benoitf commented Dec 20, 2018

I agree that today it's very difficult to users to know how to override the memory as it's based on the container name, so even if you do know the plug-in which is installed you don't know why attribute to use.
So to provide this nice UX in UD, somehow UD need to ask wsmaster

@garagatyi
Copy link

If we want to have a precise memory estimation than UD cannot do that technically.
For now, we don't even have a way how to do that on wsmaster to provide an API or so.

@slemeur slemeur mentioned this issue Dec 20, 2018
69 tasks
@l0rd
Copy link
Contributor

l0rd commented Dec 20, 2018

If we want to have a precise memory estimation than UD cannot do that technically.
For now, we don't even have a way how to do that on wsmaster to provide an API or so.

UD can do that if memory limit are in meta.yaml. UD can set the memory limit in workspcae configuration attributes. We don't need to add that to wsmaster API. Let's not make it more complicated than it is.

@l0rd
Copy link
Contributor

l0rd commented Mar 19, 2019

As a prerequisite to fix this @ibuziuk team will work on #12908

@ashumilova ashumilova added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 5, 2019
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2019
@che-bot
Copy link
Contributor

che-bot commented Dec 30, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@mmorhun
Copy link
Contributor Author

mmorhun commented Jan 2, 2020

The issue is still actual. On dashboard I still see - in the RAM column for a workspace.

@mmorhun mmorhun removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2020
@sleshchenko sleshchenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 26, 2020
@che-bot
Copy link
Contributor

che-bot commented Oct 1, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2020
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 1, 2020
@sleshchenko
Copy link
Member

The references UI is not available on the new dashboard

@mmorhun
Copy link
Contributor Author

mmorhun commented Feb 4, 2021

Is there any plans to have some indicator that shows how many resources a workspace consumes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

9 participants