Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some devfiles are not compatible with Hosted Che (che.openshift.io) due to 3 GB quota limitations #13969

Closed
5 tasks done
ibuziuk opened this issue Jul 23, 2019 · 15 comments
Closed
5 tasks done
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jul 23, 2019

Current Hosted Che "Terms of service" allows using only 3GB of RAM for workspace. At the same time some of the devfiles from the registry like java-web-spring are failing with the quota issue:

image

image

NOTE: event though globalMemoryLimit: 2674Mi is set in the meta.yaml, I suspect it does not take into account the jwt-proxy pod

We need to:

[1] https://www.eclipse.org/che/docs/che-7/hosted-che.html#terms-of-service_{context}

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 23, 2019

@Katka92 @ScrewTSW could you please provide a list of Hosted Che quota incompatible devfiles from - https://github.com/eclipse/che-devfile-registry/tree/master/devfiles ?

This could be simply tested on prod-preview ?url=https://raw.githubusercontent.com/eclipse/che-devfile-registry/master/devfiles/java-web-spring/devfile.yaml (import via factory) e.g. https://che.prod-preview.openshift.io/f?url=https://raw.githubusercontent.com/eclipse/che-devfile-registry/master/devfiles/java-web-spring/devfile.yaml

@ScrewTSW
Copy link
Member

Devfiles failing because of quota issues:

  • Apache Camel based on Spring Boot
  • Java with Spring Boot and MySQL
  • Java Spring Boot

All the other devfiles started correctly for me when I was doing the testing (19.7.2019)

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 23, 2019

@sleshchenko any comments on this issue. Do you happen to know if we could shrink RAM for those devfiles or current memory settings reflect the absolute minimum ?

@apupier
Copy link
Contributor

apupier commented Jul 23, 2019

in previous version of Che 7, the Apache Camel stack was working. it was using smaller memory values, see #13832 (comment)

@amisevsk
Copy link
Contributor

Related: #11801

@ScrewTSW
Copy link
Member

ScrewTSW commented Jul 23, 2019

[23.07.2019]
Check for worksapce startup quotes with the latest version of devfile registry at prod-preview:

  • ✓ angular
  • ✘ apache-camel-springboot [Should be fixed by PR and Follow-up]
  • ✓ dotnet
  • ✓ golang
  • ✓ java-gradle
  • ✓ java-maven
  • ✘ java-mysql [Should be fixed by PR]
  • ✘ java-web-spring [Should be fixed by PR]
  • ✓ java-web-vertx
  • ✓ nodejs-mongo
  • ✓ nodejs-react
  • ✓ nodejs
  • ✓ php-laravel
  • ✓ php-mysql
  • ✓ php-symfony
  • ✓ php-web-simple
  • ✓ python-django
  • ✓ python

@ibuziuk ibuziuk changed the title Some devfiles are not compatible with Hosted Che (che.openshift.io) due to quota issues Some devfiles are not compatible with Hosted Che (che.openshift.io) due to 3 GB quota limitations Jul 23, 2019
@sunix
Copy link
Contributor

sunix commented Jul 23, 2019

I don't know if this is the place but we should concider having 5GB quota limitations (and having less users capacity)

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 23, 2019

@sunix you could add this proposal to the upcoming briefs for Q3, but 5GB quota & less users capacity definitely not smth we are going to address by GA

@ibuziuk ibuziuk added this to the 7.0.0 milestone Jul 23, 2019
@ibuziuk ibuziuk self-assigned this Jul 23, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 24, 2019

@ibuziuk that doesn't look like a blocker right? Setting it as P1. I mean if we cannot reduce the amount of memory we can remove the devfiles from the openshift.io registry.

@l0rd l0rd added the severity/P1 Has a major impact to usage or development of the system. label Jul 24, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 24, 2019

yeah, not a blocker indeed

@apupier
Copy link
Contributor

apupier commented Jul 24, 2019

I mean if we cannot reduce the amount of memory we can remove the devfiles from the openshift.io registry.

for Apache Camel stack, we can reduce the memory, see eclipse-che/che-devfile-registry#46 and #13832

so nto having Apache Camel stack on che.openshift.io is not blocker?
an alternate solution if there is a different registry to use is to set back the working memory values only in the rh-che repository?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 24, 2019

@apupier if it works we would merge it and make available ;-)

@apupier
Copy link
Contributor

apupier commented Jul 24, 2019

@apupier if it works we would merge it and make available ;-)

my last manual tests on preprod are working eclipse-che/che-devfile-registry#46 (comment)

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 24, 2019

created a separate issue for UD improvement that should be tackled after GA - #14001

@ibuziuk ibuziuk added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 29, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 30, 2019

All PRs have been merged. Closing

@ibuziuk ibuziuk closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

6 participants