Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Jul 23, 2019

che.openshift.io eclipse-che/che#13832

Signed-off-by: Aurélien Pupier apupier@redhat.com

What does this PR do?

What issues does this PR fix or reference?

@apupier
Copy link
Contributor Author

apupier commented Jul 23, 2019

tried on https://che.prod-preview.openshift.io , the workspace is starting. Unfortunately, I have a "dial tcp 172.30.45.163:3100: connect: no route to host" which doesn't seem to be related to this PR

@apupier
Copy link
Contributor Author

apupier commented Jul 23, 2019

Unfortunately, I have a "dial tcp 172.30.45.163:3100: connect: no route to host" which doesn't seem to be related to this PR

maybe related... can reproduce only with this one.

there are error 500 reported in console log

@apupier
Copy link
Contributor Author

apupier commented Jul 23, 2019

seems an erro unrelated to memory limits.

there is "/entrypoint.sh: line 10: /home/user/.bashrc: Permission denied" in log of the "maven" pod

@apupier
Copy link
Contributor Author

apupier commented Jul 23, 2019

this error is known and not related to my PR. @amisevsk will provide a fix soon

@amisevsk
Copy link
Contributor

The entrypoint.sh issue will be resolved by #42

@amisevsk
Copy link
Contributor

To confirm, starting a workspace from the updated devfile in this PR gives the error

Terminated at Jul 23, 2019 1:51:45 PM with exit code 137 (OOMKilled)

on the vscode-camel sidecar container.

che.openshift.io eclipse-che/che#13832

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the 13832-SetLowerMemoryLimitToStillHaveStackWorkingonCheOpenShiftIo branch from 7b2b7d8 to 2b6f0af Compare July 24, 2019 07:29
@apupier
Copy link
Contributor Author

apupier commented Jul 24, 2019

updated to provide lower limits that allows each VS code extensions to start while keeping total lower than 3G

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefly tested this devfile with the rc-4.0-SNAPSHOT build and found no specific issues. I worry that the lower limits might be hit in some case I didn't cover, but it seems to work for now.

Thanks @apupier !

@ibuziuk
Copy link
Member

ibuziuk commented Jul 24, 2019

tested against prod-preview and workspace is started just fine without hitting quotas

image

@ibuziuk
Copy link
Member

ibuziuk commented Jul 24, 2019

@l0rd @rhopp are you ok to merge ?

@ScrewTSW
Copy link
Member

@apupier Hello. I've done some manual investigation myself as well. Here are my suggested values.

Maybe you can consider my proposal and possibly update this PR.

https://gist.github.com/ScrewTSW/892a1b8d3ca2a98f798f7adba0475959

@l0rd
Copy link
Contributor

l0rd commented Jul 24, 2019

The choices are:

  • merge this PR
  • remove the camel springboot devfile before GA (because it doesn't work)

+1 to merge this considered that it's a 2 lines fix

@slemeur
Copy link

slemeur commented Jul 25, 2019 via email

@apupier
Copy link
Contributor Author

apupier commented Jul 25, 2019

@apupier Hello. I've done some manual investigation myself as well. Here are my suggested values.

Maybe you can consider my proposal and possibly update this PR.

can you explain the modification of the values? What are they improving more precisely?

I tried with these values and I cannot launch the "Tasks". There is an error in browser console:
task ERROR Can't get task launch configuration for label: run the services but cannot find anything in pod log explaining that.

@ScrewTSW
Copy link
Member

@apupier Hello. I've done some manual investigation myself as well. Here are my suggested values.
Maybe you can consider my proposal and possibly update this PR.

can you explain the modification of the values? What are they improving more precisely?

I tried with these values and I cannot launch the "Tasks". There is an error in browser console:
task ERROR Can't get task launch configuration for label: run the services but cannot find anything in pod log explaining that.

That's strange. I've been running it on prod-preview starter-2a-cluster with no issues, running all tasks. I've modified the values based on the commands execution and demo app deployment and testing. I've looked into the cluster monitoring to see how much memory the runners consume and modified the values based on that.

@ibuziuk ibuziuk merged commit 6c0be1e into eclipse-che:master Jul 25, 2019
@apupier apupier deleted the 13832-SetLowerMemoryLimitToStillHaveStackWorkingonCheOpenShiftIo branch July 26, 2019 07:45
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants