Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ability filter user containers from among others #11804

Closed
AndrienkoAleksandr opened this issue Nov 1, 2018 · 7 comments
Closed

Apply ability filter user containers from among others #11804

AndrienkoAleksandr opened this issue Nov 1, 2018 · 7 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Nov 1, 2018

Description

In the Che 7 Workspace Model, a user is able to define a list of own "containers" and apply Che Plugins "tooling containers". Then all containers(machines) are available in Workspace#getRuntime#getMachines but it is not possible to identify which of containers are user-defined.
It makes sense to have an ability to identify where container comes from User Recipe or Che Plugin since this list is used for opening a terminal, executing of command.
A special attribute in Machine#getAttributes would be fine.

@AndrienkoAleksandr AndrienkoAleksandr added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels Nov 1, 2018
@garagatyi
Copy link

Well, sometimes it makes sense to execute command or have a terminal into tolling containers too! For example into Theia container

@sleshchenko
Copy link
Member

Well, sometimes it makes sense to execute command or have a terminal into tolling containers too! For example into Theia container

@garagatyi Yeah, I agree. Let me clarify that Client would be able not just filter machines, but like order them (like first user-defined and then tooling) or display some labels near machine names to make it clear where it comes from.

@skabashnyuk
Copy link
Contributor

@evidolob @AndrienkoAleksandr I think I clarified my concerns with @l0rd. Maven/Git would not be a Che plugin as a separate sidecar. This issue has the correct and right description. You can proceed. Please don't forget that in multiuser Che jwt-proxy can be added and it's not a Che plugin and it's not defined in user recipe.

@slemeur
Copy link
Contributor

slemeur commented Jan 10, 2019

What is your proposal for jwt-proxy then?

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Jan 10, 2019

What is your proposal for jwt-proxy then?

Identify jwt-proxy in the same way as we identify Che Plugins as something that comes not from user recipe.

@AndrienkoAleksandr
Copy link
Contributor Author

@skabashnyuk @evidolob @garagatyi @l0rd I created pull request #12386 to begin disscussion how to resolve this issue in best way.

@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Jan 16, 2019

Need for eclipse-che/che-theia#21 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

5 participants