-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On the go workspace config: detect if a service that is listening to a port and propose to expose it #12061
Comments
I discussed this topic with Florent and did some investigations. |
According to this article we can expose a port without declaring it in a pod. In this case, a user starts an application and after some time we automatically detect this and open a port and can show a notification about it.
We can start from a simple approach:
|
Can't we use a theia plugin to watch for processes listening to ports (instead of having a separate binary)?
I believe that you want the call to happen Che server side because a process running in the theia container doesn't have enough privileges to create a route but can't we use a service account that has those privileges as we do for the terminal plugin (or use the same service account)? I am totally ok with the approach otherwise! |
@l0rd it is what I'm suggesting in the simple approach section
|
UX could be this one: eclipse-che/che-theia#51 :-) |
It is an interesting solution that doesn't have issues that 2 suggested ones have. So +1 |
@benoitf this UX looks really great ;-) Are you planning to take care of this issue ? |
@ibuziuk yes I think it will be addressed with eclipse-che/che-theia#51 |
Fixed by: eclipse-che/che-theia#51 |
@benoitf what steps should a user take to make this work? I mean I have tried with spring boot application and it didn't work: when I started the application I wasn't asked to expose the port. Is there something to configure? |
@l0rd I will work on it (basically it doesn't work because the plug-in is not enabled by default ;-) |
Ok thanks @benoitf |
eclipse-che/che#12061 Change-Id: I6a0087eba9e5b39ab866bcdf095489552f974bfd Signed-off-by: Florent Benoit <fbenoit@redhat.com>
eclipse-che/che#12061 Change-Id: I6a0087eba9e5b39ab866bcdf095489552f974bfd Signed-off-by: Florent Benoit <fbenoit@redhat.com>
eclipse-che/che#12061 Change-Id: I6a0087eba9e5b39ab866bcdf095489552f974bfd Signed-off-by: Florent Benoit <fbenoit@redhat.com>
eclipse-che/che#12061 Change-Id: I6a0087eba9e5b39ab866bcdf095489552f974bfd Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@l0rd done, it is now added by default |
Yes it's working fine currently so let's close it |
Description
The text was updated successfully, but these errors were encountered: