Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Che 7 model fields that don't follow camel case #12501

Closed
garagatyi opened this issue Jan 23, 2019 · 4 comments
Closed

Rename Che 7 model fields that don't follow camel case #12501

garagatyi opened this issue Jan 23, 2019 · 4 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

garagatyi commented Jan 23, 2019

Description

Rename Che 7 model fields that use dash instead of camel case.
che-plugin.yaml:

Reproduction Steps

OS and version:

Diagnostics:

@metlos
Copy link
Contributor

metlos commented Jan 23, 2019

Not sure if all of https://github.com/eclipse/che-plugin-broker/blob/master/model/model.go is used in che-plugin.yaml but there seem to be more such fields than just the 2 mentioned.

For example workspace-env is used for sure.

@garagatyi
Copy link
Author

You are completely right. Thanks for noticing.

@garagatyi
Copy link
Author

Added to the description of the issue

@garagatyi
Copy link
Author

Issue fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

2 participants