Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Rename Che 7 model fields that don't follow camel case #1217

Closed
garagatyi opened this issue Jan 23, 2019 · 5 comments
Closed

Rename Che 7 model fields that don't follow camel case #1217

garagatyi opened this issue Jan 23, 2019 · 5 comments
Assignees
@garagatyi

Comments

@garagatyi
Copy link

Placeholder for eclipse-che/che#12501
@garagatyi
Copy link
Author

If we change the code in the brokers Che 7 workpsace of OSIO won't start until we deliver that version of upstream Che.
I think we can:

  1. Add compatibility with new fields names to plugin brokers (and leave compatibility with the old ones)
  2. Add compatibility with new fields names on Che master side (and leave compatibility with the old ones)
  3. Update editors/plugins that use old fields to have both versions of names
  4. Update registry
  5. After a couple of releases remove compatibility stuff

@ibuziuk @l0rd @slemeur WDYT?

@ibuziuk
Copy link
Member

ibuziuk commented Jan 29, 2019

@garagatyi sounds relevant for me

@l0rd
Copy link
Contributor

l0rd commented Jan 29, 2019

  1. Update editors/plugins that use old fields to have both versions of names
  2. Update registry

That means that we will have 2 copies of the same plugin. How will we handle this? Shouldn't we do these only after a couple of releases (i.e. prepare the PR but merge it after release of 6.19)?

@garagatyi
Copy link
Author

@l0rd I'm not going to duplicate the plugin in the registry, I want to duplicate just a couple of fields in the che-plugin.yaml of those plugins.

garagatyi pushed a commit to garagatyi/che-editor-eclipseide that referenced this issue Jan 30, 2019
Add new field for memory limit, fix some typos
101449d 
Add a new field for memory limit in addition to an existing one.
Existing one will be removed later. 
See redhat-developer/rh-che#1217
garagatyi pushed a commit to eclipse-che/che-editor-gwt-ide that referenced this issue Jan 30, 2019
Add new field for memory limit, fix some typos
1f2e6ec 
Add a new field for memory limit in addition to an existing one.
Existing one will be removed later. 
See redhat-developer/rh-che#1217
garagatyi pushed a commit to ws-skeleton/che-editor-jupyter that referenced this issue Jan 30, 2019
Add new field for memory limit
46a16f5 
Add a new field for memory limit in addition to an existing one.
Existing one will be removed later. 
See redhat-developer/rh-che#1217
garagatyi pushed a commit to garagatyi/che-theia-dev-plugin that referenced this issue Jan 30, 2019
Add new field for memory limit
9cea37e 
Add a new field for memory limit in addition to an existing one.
Existing one will be removed later. 
See redhat-developer/rh-che#1217
Changed editor commads fields since they contain dummy command only.
This was referenced Jan 30, 2019
Merged
Merged
Merged
Merged
benoitf pushed a commit to che-incubator/che-theia-dev-plugin that referenced this issue Jan 31, 2019
@benoitf
Add new field for memory limit
3af458c 
Add a new field for memory limit in addition to an existing one.
Existing one will be removed later. 
See redhat-developer/rh-che#1217
Changed editor commads fields since they contain dummy command only.
@garagatyi garagatyi self-assigned this Jan 31, 2019
@garagatyi
Copy link
Author

Issue fixed in upstream Che

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@garagatyi garagatyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@l0rd @ibuziuk @garagatyi