Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify 'latest' version of plugins in workspaces definitions #12937

Closed
1 of 2 tasks
l0rd opened this issue Mar 20, 2019 · 9 comments
Closed
1 of 2 tasks

Allow to specify 'latest' version of plugins in workspaces definitions #12937

l0rd opened this issue Mar 20, 2019 · 9 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 20, 2019

Description

Although it's important to be able to specify a particular version of a plugin/editor to be included in a workspace or stack, in most cases we just need latest version.

This issue is to allow a definition of a workspace plugin without a specific version:

id: che-machine-exec-plugin

and with version latest:

id: che-machine-exec-plugin:latest

This should work for devfiles, workspaces json and stacks.

Subtasks created:

@l0rd l0rd mentioned this issue Mar 20, 2019
@l0rd l0rd added team/osio kind/enhancement A feature request - must adhere to the feature request template. labels Mar 20, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Apr 25, 2019

A potential solution is to create "latest" folder which would always duplicate the highest version of the plugin

@ibuziuk
Copy link
Member

ibuziuk commented Apr 26, 2019

@l0rd am I correct that plugin without version e.g. id: che-machine-exec-plugin = latest ?

@l0rd
Copy link
Contributor Author

l0rd commented Apr 26, 2019

Yes you are correct

@ibuziuk
Copy link
Member

ibuziuk commented Apr 26, 2019

For me, it looks like a relatively simple issue that can be delivered in the 2 steps manner (and even split into two issues):

  • id: che-machine-exec-plugin:latest case can be solved by the creation and a requirement for all v2 plugin always having the latest folder with the dedicated content (chagnes) - estimate (1-2 sp.)
  • id: che-machine-exec-plugin case should be tackled on wsmaster / plugin broker side (when version is missing always fall back on the latest) - estimate (3p.)

@l0rd does this sound like a good plan? If yes, I would create 2 dedicated rh-che issues for the next sprint planning.

@l0rd
Copy link
Contributor Author

l0rd commented Apr 28, 2019

@ibuziuk yes that looks like a good plan. Another thing you need to take care of are the versions of the exec and theia that are automatically added by wsmaster (when a user do not specify them in a Devfile). You should probably use version 'latest' for both and it could be part of the first task.

@amisevsk
Copy link
Contributor

A PR for latest folders is here: eclipse-che/che-plugin-registry#143, but I don't know if this is the direction we want to go in. Ideally the plugin registry is more than a httpd server and can return the latest version by itself -- manually maintaining latest dirs in the registry could be error-prone.

@che-bot
Copy link
Contributor

che-bot commented Dec 30, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2019
@amisevsk
Copy link
Contributor

amisevsk commented Jan 6, 2020

Closing as the core issue here is out of date. Latest folders are included in the plugin registry now.

@amisevsk amisevsk closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants