If the plugin version is not specified - fall back on latest

[ibuziuk]

This issue is to allow a definition of a workspace plugin without a specific version:

• id: che-machine-exec-plugin - in this case, the latest version of the plugin should be used.

the case should be tackled on wsmaster / plugin broker side (when version is missing always fall back on the latest).

Another thing we need to take care of are the versions of the exec and theia that are automatically added by wsmaster (when a user do not specify them in a Devfile).

[ibuziuk]

On ws-master side:

• changes required in Devfile config to not specify the version of plugin at all - https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-devfile/src/main/resources/schema/devfile.json#L175

• modify parsing of the plugin version in FQNParser - https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/wsplugins/PluginFQNParser.java#L68

• Default editor provisonser / Default Plugin Provisioner - https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-devfile/src/main/java/org/eclipse/che/api/devfile/server/convert/DefaultEditorProvisioner.java

properties

• https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L627
• https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L630
• https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L639
• https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L647

And there should be a change on the plugin-broker side:

• https://github.com/eclipse/che-plugin-broker/blob/c90e7d4993d7c6d591d921cf8ef685745bcce968/brokers/unified/broker.go#L148

[nickboldt]

another use case is if the plugin version IS specified but doesn't exist. see eclipse-che/che-plugin-registry#319 for a workaround (hardcoding all the old versions of 7.y.z plugins in the master branch).

So if you were running 7.3.3 and updated to 7.6/master you'd break because the new plugin reg would be missing 7.3.3 theia and machine-exec plugins.

[ibuziuk]

Closed in favour of eclipse-che/che#15447

another use case is if the plugin version IS specified but doesn't exist. see eclipse-che/che-plugin-registry#319 for a workaround (hardcoding all the old versions of 7.y.z plugins in the master branch).

So if you were running 7.3.3 and updated to 7.6/master you'd break because the new plugin reg would be missing 7.3.3 theia and machine-exec plugins.

@nickboldt please, create a separate upstream issue for that