Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest plugin registry does not include theia/machine-exec versions 7.3.2, 7.3.3 #15444

Closed
2 tasks done
amisevsk opened this issue Dec 10, 2019 · 4 comments · Fixed by eclipse-che/che-plugin-registry#319
Closed
2 tasks done
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@amisevsk
Copy link
Contributor

Describe the bug

The master branch of the plugin registry does not include che-theia and che-machine-exec plugins for version 7.3.2 or 7.3.3. This means any user who manually added these plugins to a devfile will not be able to start workspace after rolling out a new update.

Che version

  • latest (not present in 7.5.1 either)
  • nightly

Expected behavior

Release x.x.x > y.y.y should have all plugins in y.y.y.

Additional info

Impact should be minimal since the editor and machine-exec are typically controlled via the default editor/plugins properties, so devfiles automatically "update" to the current release on rollout.

@amisevsk amisevsk added kind/bug Outline of a bug - must adhere to the bug report template. area/plugin-registry labels Dec 10, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 10, 2019
@amisevsk
Copy link
Contributor Author

Fixed by PR eclipse-che/che-plugin-registry#319 but this does not apply to 7.5.1 release.

@nickboldt
Copy link
Contributor

Alternative idea...

can the plugin broker, if it is asked for a version that doesn't exist... simply grab /latest as a fallback behaviour? Better that than:

  • forced hardcoding of old versions / dead boilerplate code
  • breaking compatibility when we forget to push 7.y.z+1 versions into master

Because your fix only works for 7.3.2 and 7.3.2, and you're missing 7.5.1 which kinda proves my point -- it's easy to forget about point releases.

So.. either have 7.3.z requests "fall back" to 7.3.0 if the zth plugin is not found, or fall back to /latest when zth plugin not found.

@amisevsk
Copy link
Contributor Author

Maybe, I'd say create an issue for that feature request. Worth noting also that 7.5.1 is already in master. I'm reluctant to try to "magically" fix problems in devfiles.

@nickboldt
Copy link
Contributor

related issue redhat-developer/rh-che#1396

@tolusha tolusha removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants