Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che registries (plugin+devfile) should be part of Che deployment #13557

Closed
3 tasks done
l0rd opened this issue Jun 17, 2019 · 8 comments
Closed
3 tasks done

Che registries (plugin+devfile) should be part of Che deployment #13557

l0rd opened this issue Jun 17, 2019 · 8 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Jun 17, 2019

By default Che plugin and Che devfile registries should be deployed along with the wsmaster. This is mainly needed to make sure that the version of the wsmaster and the version of those registries are always consistent. A user should still be able to use an already deployed registry but the default should be do deploy a new instance (as per keycloak and postgres for multi-user Che).

Sub tasks:

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. target/che7GA labels Jun 17, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Jun 17, 2019

cc @slemeur @nickboldt @rhopp

@tsmaeder
Copy link
Contributor

So the idea is to have a registry for "latest", one for "next", etc.?

@l0rd
Copy link
Contributor Author

l0rd commented Jun 18, 2019

@tsmaeder nightly, latest, 7.0.0, 7.1.0 etc...

@skabashnyuk
Copy link
Contributor

AFAIK last time we think about such kind of issue was minimum memory requirements to start che locally. Is this something that is no longer in our list?

@skabashnyuk
Copy link
Contributor

@l0rd can you confirm that increased memory requirement ~500m for local development are acceptable and expected.

@l0rd
Copy link
Contributor Author

l0rd commented Jun 26, 2019 via email

@skabashnyuk
Copy link
Contributor

Don't know yet, we can try. Not sure about 50mb may be 100mb.

@sparkoo
Copy link
Member

sparkoo commented Jul 18, 2019

From @metlos's experiments, 16MB is minimum to run registry without performance drop. He tested with 1000 sequential requests.
I've set memoryLimit: 32Miand memoryRequests: 16Mi in #13890.

@l0rd l0rd added team/osio status/in-progress This issue has been taken by an engineer and is under active development. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 23, 2019
@skabashnyuk skabashnyuk removed their assignment Jul 24, 2019
@l0rd l0rd closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

5 participants