fix(operator): Don't deploy a registry if its url is specified as an argument #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when installing with the operator This is to have the same behavior as the `helm` installer Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
requested review from
azatsarynnyy,
benoitf,
l0rd,
rhopp and
vparfonov
as code owners
davidfestal
changed the title
l0rd
approved these changes
Jul 24, 2019
davidfestal
changed the title
benoitf
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't deploy a registry if its url is specified as an argument when installing with the operator.
This PR is to have, with the
operatorinstaller, the same behavior as thehelminstaller: https://github.com/che-incubator/chectl/blob/master/src/installers/helm.ts#L210What issues does this PR fix or reference?
This is related to eclipse-che/che#13557