-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide VS Code AtlasMap extension in Che plugin registry #13922
Comments
several of these issues are nto specific to Che but can be reproduced in Theia eclipse-theia/theia#5007 |
I would vote for not including this issue in Che 7 GA, as we are pretty close to release and this seems to have lot of problems. Setting 7.1 milestone. |
The Ui is no more even displayed. the content of the frame seems normal(to verify but as far as I remember everything was coming with scripts) If I reach the "provided URi" like http://server89h0rf9e-theia-idepea-server-13131.192.168.1.22.nip.io/ , I can access the AtlasMap data UI using Che-Theia@4ef1d89 using Theia@4ef1d89 on minikube installed with chectl -a operator I noticed in browser console that the connection was refused for the scripts, I suppose that I have not clicked "fast-enough" to enable" the redirection: |
Using the new recommended way of using webviews and deactivating x-frame-options I have different error on latest Che:
as far as I know, AtlasMap is not using ServiceWorkers |
based on coder/code-server#997 (comment) "service workers will only work over secure origins (localhost/127.0.0.1 or https)." which explains why i tis working in Theia (it was on localhost) and why it is nto in my Ch einstance as it is using http. |
Florent mentioned that TLS needs to be used to have https on the internal routes used between containers. |
pointed out to #14035 (comment) also need to start with |
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Tested with TLS activated, using latest chectl and still not working :-(
added the Certificate to Chrome:
There are no errors in the console browser.
|
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier still a wip or there Is something we could merge ? |
this is still not working. |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
tested with latest CodeReady Workspaces and latest VS Code AtlasMap. in Red Hat developer sandbox with version used:
the pointed gist contains:
when calling, "Open AtlasMap" command, the webview is opening but it has an empty black screen.
the #document inside the iframe is```html <style id="_defaultStyles"> body { background-color: var(--vscode-editor-background); color: var(--vscode-editor-foreground); font-family: var(--vscode-font-family); font-weight: var(--vscode-font-weight); font-size: var(--vscode-font-size); margin: 0; padding: 0 20px; }
|
@apupier that stack trace indicates that the Che API doesn't work in the plugin host. We had a bug that was fixed some time ago, but probably not in that version. I don't know if that could affect webviews (might need che API to provide route URIs, maybe?) |
with Che 7.36.0-SNAPSHOT installed through chectl chectl/0.0.20210906-next.57d4d7e linux-x64 node-v12.22.6 In Console log, now there are these errors (which doesn't sound related to the problem itself):
|
There is a black screen also with Pure Theia. (followed https://github.com/eclipse-theia/theia/wiki/Testing-VS-Code-extensions to test it) |
Have it working in Theia. |
using the provided fix in Theia, it doesn't work in Che. Even in the "preview". By looking at Che behavior, this is not vey surprising as the main fix in Theia is related to redirect with To try, use this devfile to use the image built with this PR:
The strange things that I notice are:
The referenced file all returned a 302 with a redirection to
So sounds like this script is not called? How to investigate that? |
From the VS Code AtlasMap container, if I call it stays blocked on for several minutes: then: it could explain why the injected script by VS Code AtlasMap is not replacing the webview html with actual AtlasMap UI. |
in the dom of the Preview, it sounds like it is able to resolve the initial script, the content is:
but the page remains blank note: tested with a simpler devfile:
|
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
https://marketplace.visualstudio.com/items?itemName=redhat.atlasmap-viewer
The text was updated successfully, but these errors were encountered: