Generated Hello World plugin build fails

[mmorhun]

Describe the bug

Generated backend Hello World plugin cannot be build with yarn command by default

Che version

Che master: nightly
Che Theia: 7.0.0-rc-3.0

Steps to reproduce

1. Create a workspace with Che Theia as IDE
2. Generate backend Hello World plugin using Yeoman Wizard command
3. Open terminal in dev container (eclipse/che-theia-dev:next), go to the plugin root and execute yarn command to build it
4. Build fails with error:

Build log

(theia-dev@container) (/projects/test1) $ yarn
yarn install v1.16.0
warning package.json: License should be a valid SPDX license expression
warning test1@0.0.1: License should be a valid SPDX license expression
[1/5] Validating package.json...
warning test1@0.0.1: License should be a valid SPDX license expression
warning test1@0.0.1: The engine "theiaPlugin" appears to be invalid.
[2/5] Resolving packages...
success Already up-to-date.
$ yarn run clean && yarn run build
yarn run v1.16.0
warning package.json: License should be a valid SPDX license expression
warning test1@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ rimraf lib
Done in 0.15s.
yarn run v1.16.0
warning package.json: License should be a valid SPDX license expression
warning test1@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ yarn run format-code && yarn run compile && theia:plugin pack
warning package.json: License should be a valid SPDX license expression
warning test1@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ tsfmt -r
warning package.json: License should be a valid SPDX license expression
warning test1@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ tsc
node_modules/@theia/plugin/src/theia.d.ts:8157:19 - error TS2304: Cannot find name 'Comment'.

8157         comments: Comment[];
                       ~~~~~~~


node_modules/@theia/plugin/src/theia.d.ts:8312:80 - error TS2304: Cannot find name 'Comment'.

8312         createCommentThread(id: string, resource: Uri, range: Range, comments: Comment[]): CommentThread;
                                                                                    ~~~~~~~


error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Expected behavior

Build should be successful

Runtime

minishift v1.34.1+c2ff9cb
oc v3.11.0+0cbc58b

Installation method

chectl

Environment

Linux

Additional context

If add skipLibCheck: true into tsconfig.json everything works as expected.

[tsmaeder]

@mmorhun any idea why it fails to build?

[tsmaeder]

Tagging this p2/7.0, since we can't really break che if we fix it.

[mmorhun]

@tsmaeder I don't know exact reason of it. Some time ago it worked. I think the start point is skopLibCheck flag. Anyway, it needs to be investigated.

[benoitf]

@mmorhun what is the version of theia used in the generated package.json ?

[mmorhun]

Generated package.josn

{
      "name": "test1",
      "publisher": "theia",
      "keywords": [
        "theia-plugin"
      ],
      "version": "0.0.1",
      "license": "none",
      
      "files": [
        "src"
      ],
      "devDependencies": {
        "@theia/plugin": "next",
        "@theia/plugin-packager": "latest",
        "rimraf": "2.6.2",
        "typescript-formatter": "7.2.2",
        "typescript": "2.9.2"
      },
      "scripts": {
        "prepare": "yarn run clean && yarn run build",
        "clean": "rimraf lib",
        "format-code": "tsfmt -r",
        "watch": "tsc -watch",
        "compile": "tsc", 
        "build": "yarn run format-code && yarn run compile && theia:plugin pack"
      },
      "engines": {
        "theiaPlugin": "next"
      },
      "theiaPlugin": {
            "backend": "lib/test1-backend.js"
      }
}