Add missed stub Comment API #5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurinnoy
requested review from
benoitf,
evidolob,
akosyakov,
vinokurig and
vince-fugnitto
benoitf
approved these changes
Jul 31, 2019
vinokurig
approved these changes
Jul 31, 2019
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
force-pushed
the
vscode-api-comment
branch
from
a0051dd
to
fc2905d
Compare
|
@vince-fugnitto all checks passed, could you please verify the fix now? |
vince-fugnitto
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
I tested against the following issue in the theia-generator-plugin and it successfully compiled when updating the @theia/plugin extension to use the one updated by your patch.
Nice work 👍
I performed the following use case:
- generate a backend plugin and selected the 'hello-world' example. (failed due to
Comment) - updated the
package.jsonto instead use the@theia/pluginextension from this patch (using a local npm dependency) and the build successfully passed - to be certain, I also tested the
masterstate using the local npm dependency and it didn't compile (meaning the fix is truly your patch)
|
@vince-fugnitto thanks! @akosyakov I'm going to merge this PR if there is no objection |
|
@akurinnoy i'm fine since @vinokurig explained why it cannot be removed and @vince-fugnitto tested it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com
Plugin API lacks some of necessary interfaces that makes Theia plugins fail on build. That was introduced in [Plugin-Api] Add stub comment Plugin-Api .
This PR adds missed interfaces which fixes the problem.
fix eclipse-che/che#14028