The theia sample of hello world plugin build failed on Windows

[tom-shan]

Describe the bug

comes from another issue eclipse-theia/theia#5849 (comment)

eclipse/che-theia-samples version

• latest

Steps to reproduce

1 git clone https://github.com/eclipse/che-theia-samples
2 cd che-theia-samples/samples/hello-world-backend-plugin
3 yarn

Expected behavior

build successfully

Screenshots

yarn install v1.16.0
[1/5] Validating package.json...
warning @eclipse-che/hello-world-backend-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "@theia/plugin-packager > glob-promise@3.4.0" has unmet peer dependency "glob@*".
[5/5] Building fresh packages...

$ yarn run clean && yarn run build
yarn run v1.16.0
warning @eclipse-che/hello-world-backend-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ rimraf lib
Done in 0.27s.
yarn run v1.16.0
warning @eclipse-che/hello-world-backend-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ yarn run format-code && yarn run compile && theia:plugin pack
warning @eclipse-che/hello-world-backend-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ tsfmt -r
replaced C:/che-theia-samples/samples/hello-world-backend-plugin/src/hello-world-backend-plugin.ts
warning @eclipse-che/hello-world-backend-plugin@0.0.1: The engine "theiaPlugin" appears to be invalid.
$ tsc
The filename, directory name, or volume label syntax is incorrect.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Environment

Windows

[ibuziuk]

@evidolob if it is windows specific only, I suppose we can move it to 7.x (up to the team to decide in which milestone this issue could be tackled). We could also put open-for-dev label

[SimonJohnCastle]

Just want to add I have the same or similar problem on gitpod, trying to get familiar in theia-ide/theia

[SimonJohnCastle]

It looks like this can be fixed by changing "theia:plugin pack" to "theia-plugin pack" in the package.json build script. the "-" version appears to run on both Windows and Linux

In the yarn.lock the @theia/plugin-packager is set at 0.0.1-1539891078, this needs upgrading to "@theia/plugin-packager": "0.0.1-1551941037"

issue yarn upgrade to fix this
Then the build works correctly under Windows and Linux