Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision user name and email into git configuration from user profile when newly workspace is created #14416

Closed
vzhukovs opened this issue Sep 4, 2019 · 5 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@vzhukovs
Copy link
Contributor

vzhukovs commented Sep 4, 2019

Is your enhancement related to a problem? Please describe.

There is a need to provide user name and email into git configuration on workspace creation step in case if user preferences doesn't have git configuration. This means that git configuration should be taken from user profile.

Describe the solution you'd like

When workspace starts up, we check if we have preference related to git.user.name and git.config.name. If properties exist, then we configure git config with the last ones, otherwise, we take user name and email from user profile instead.

Describe alternatives you've considered

--

Additional context

--

@vzhukovs vzhukovs added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 4, 2019
@vzhukovs vzhukovs added this to the 7.2.0 milestone Sep 4, 2019
@vzhukovs vzhukovs self-assigned this Sep 4, 2019
@azatsarynnyy
Copy link
Member

@l0rd this one is based on your feedback. Could you set a priority, please

@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Sep 4, 2019
@sunix
Copy link
Contributor

sunix commented Sep 4, 2019

to me this should have been implemented in #13874 ... so should have the same priority and milestone

@sunix
Copy link
Contributor

sunix commented Sep 4, 2019

So let's say that a user has setup Che and configured a Che user and started a workspace with it. Could we, if these have not been set previously, preconfigure/set the git username and git email with the Che user information?

@vzhukovs
Copy link
Contributor Author

vzhukovs commented Sep 4, 2019

It was decided in comments to the demo video to implement this enhancement in 7.2.0

@sunix sunix added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 4, 2019
@vzhukovs
Copy link
Contributor Author

vzhukovs commented Sep 4, 2019

Could we, if these have not been set previously, preconfigure/set the git username and git email with the Che user information?

That is the point of this enhancement. To provide user name and email into git configuration if user' preferences don't have anything related to git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants