Provision name and email from user profile if preferences are empty #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
added
kind/enhancement
vzhukovs
requested review from
amisevsk,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
the
status/code-review
|
ci-build |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
metlos
reviewed
Sep 11, 2019
...org/eclipse/che/workspace/infrastructure/kubernetes/provision/GitUserProfileProvisioner.java
Outdated
Show resolved
Hide resolved
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
amisevsk
approved these changes
Sep 11, 2019
...org/eclipse/che/workspace/infrastructure/kubernetes/provision/GitUserProfileProvisioner.java
Outdated
Show resolved
Hide resolved
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
amisevsk
approved these changes
Sep 11, 2019
metlos
approved these changes
Sep 12, 2019
Signed-off-by: Vlad Zhukovskyi <vzhukovs@redhat.com>
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal adds a behavior when user name and user email from user profile is taken to provision default git configuration, when user preferences are empty. But, when user preferences are contain information about user name and email, then user name and email from user profile is ignored.
Signed-off-by: Vlad Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
#14416
Release Notes
Provision name and email from user profile if preferences are empty
Docs PR
N/A