Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal doesn't work #15969

Closed
sharoncafa01 opened this issue Feb 9, 2020 · 15 comments · Fixed by eclipse-che/che-devfile-registry#196
Closed

Terminal doesn't work #15969

sharoncafa01 opened this issue Feb 9, 2020 · 15 comments · Fixed by eclipse-che/che-devfile-registry#196
Assignees
Labels
area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone

Comments

@sharoncafa01
Copy link

Hi.
For 5 days I tried to start the terminal.
After I wrote a program i wanted to check and start it, but the terminal didn't work.
It's like it doesn't work, in fact I can't write on it.
What can I do?

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 9, 2020
@RomanNikitenko
Copy link
Member

@sharoncafa01
thank you for reporting the issue!

I tried to start a new terminal and it works for me!
I use:

  • minikube version: v1.6.2
  • chectl/0.0.20200207-next.b3dcac3 linux-x64 node-v10.19.0
  • che version
    che-version

could you provide more details how to reproduce the issue?

@sharoncafa01
Copy link
Author

sharoncafa01 commented Feb 9, 2020 via email

@ibuziuk ibuziuk added status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 10, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Feb 10, 2020

@RomanNikitenko thank you for following up on that. I have added the info-needed label, since this does look like abnormal behavior
@sharoncafa01 please, provide more details wirh steps to reproduce

@RomanNikitenko
Copy link
Member

@sharoncafa01
I see your answer, but there are empty areas instead of screenshots:

empty

So, more details will help to reproduce and fix the issue.
thank you!

@dublmozga
Copy link

The same thing with READY-TO-GO STACK in
Stack with C/C++ and Clang 8 workspace. also i tried the stack for GO and in this time all worked properly

@RomanNikitenko
Copy link
Member

@dublmozga
I tried

Stack with C/C++ and Clang 8 workspace

and can not reproduce the issue.
cpp_terminal

Please provide more info about your assembly and steps to reproduce.
thank you!

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Feb 11, 2020

@dublmozga @sharoncafa01
I can reproduce it on https://che.openshift.io for Stack with C/C++ and Clang 8 workspace.
thank you for reporting the issue!

@ibuziuk it's definitely bug on https://che.openshift.io, locally on minikube I can not reproduce it.

@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Feb 11, 2020
@RomanNikitenko
Copy link
Member

As workaround, user can change version of machine-exec service, it helped me to get terminal working.

workaround_terminal

@RomanNikitenko RomanNikitenko added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 11, 2020
@dublmozga
Copy link

Yes, thanks. That helped to me too.

@azatsarynnyy
Copy link
Member

it's interesting that the terminal works well after disabling the cpp-tools plugin

@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 12, 2020
@rhopp
Copy link
Contributor

rhopp commented Feb 12, 2020

One thing I noticed, that tasks works, if the terminal wasn't opened before... But once the terminal is opened, tasks stop working as well...

@sleshchenko
Copy link
Member

Recently, I faced a similar issue on minishift, and it was by entrypoint I specified in my Devfile.
I quickly checked and it seems to be the same issue. So, I've created a fix into devfile registry that workarounds the problem eclipse-che/che-devfile-registry#196

I'll try to handle the default shell detector issue in one of my PRs in che-machine-exec if I fail - will create a dedicated issue for that.

@sleshchenko
Copy link
Member

@rhopp @sharoncafa01
Are you able to check with update Devfile:

Devfile without overridden entrypoint
metadata:
  name: cpp-terminal-test
projects:
  - name: cpp-hello-world
    source:
      location: 'https://github.com/che-samples/cpp-hello-world'
      type: git
      branch: master
attributes:
  persistVolumes: 'false'
components:
  - id: che-incubator/cpptools/latest
    preferences:
      clangd.path: /usr/bin/clangd
      cdt.clangd.binaries.enable: false
    type: chePlugin
    alias: cpp-plugin
  - mountSources: true
    memoryLimit: 512Mi
    type: dockerimage
    alias: cpp-dev
    image: 'quay.io/eclipse/che-cpp-rhel7:nightly'
apiVersion: 1.0.0
commands:
  - name: build
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/cpp-hello-world'
        type: exec
        command: g++ -g hello.cpp -o hello.out && echo "Build complete"
        component: cpp-dev
  - name: run
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/cpp-hello-world'
        type: exec
        command: ./hello.out
        component: cpp-dev
  - name: debug
    actions:
      - referenceContent: |
          {
            "version": "0.2.0",
            "configurations": [
                {
                    "type": "gdb",
                    "name": "Debug c++ application",
                    "request": "launch",
                    "program": "/projects/cpp-hello-world/hello.out"
                }
            ]
          }
        type: vscode-launch

@sleshchenko sleshchenko added area/machine-exec and removed area/editor/theia Issues related to the che-theia IDE of Che labels Feb 17, 2020
@sleshchenko sleshchenko self-assigned this Feb 17, 2020
@sleshchenko sleshchenko added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 17, 2020
@sleshchenko
Copy link
Member

It should not actual for new workspaces once devfile-registry is updated to the latest eclipse-che/che-devfile-registry#196

For existing workspace - the fix could be done manually by removing command, arg for dev container.
@sharoncafa01 Thanks for reporting it!

@nickboldt nickboldt added this to the 7.9.0 milestone Feb 24, 2020
@nickboldt
Copy link
Contributor

Setting milestone = 7.9.0 so it's easier to know WHEN THIS WAS FIXED and therefore in which release I can get it.

Please try to make your issues' milestones match the reality of when they're resolved. It makes downstreaming work much easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants