Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] How to add VSCode Extension to Eclipse Che? #15982

Closed
leehyeongrak opened this issue Feb 11, 2020 · 13 comments
Closed

[docs] How to add VSCode Extension to Eclipse Che? #15982

leehyeongrak opened this issue Feb 11, 2020 · 13 comments
Assignees
Labels
area/doc Issues related to documentation area/plugins status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@leehyeongrak
Copy link

Problem

I've seen in the documentation that I can add an extension of vscode to eclipse.
https://che.eclipse.org/eclipse-che-7-extending-developer-workspaces-to-run-vs-code-extensions-in-the-cloud-cbe97e11d4d4
But it only show the possibility and doesn't seem to tell me how to use it in eclipse che.

I'm using theia as the default frontend IDE of Eclipse Che
I know how to add the plugin provided by che, but I don't know how to add various plugins of vscode.
I know that there is a jenkins plugin in vscode.
I want to add Jenkins Extension to Eclipse Che
How to add VSCode Extension to Eclipse Che?

Relevant information

I have using eclipse che latest version

@leehyeongrak leehyeongrak added the kind/question Questions that haven't been identified as being feature requests or bugs. label Feb 11, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 11, 2020
@tolusha tolusha added the area/doc Issues related to documentation label Feb 11, 2020
@tolusha
Copy link
Contributor

tolusha commented Feb 11, 2020

I completed the following steps:

  1. Prepare a docker container with all necessary dependencies. It is a container where your plugin will be run. See the available containers fro Eclipse Che plugins https://github.com/che-dockerfiles/
  2. Create a meta.yaml file, see my example [1]. Basically you have to define your container and vsix files here.
  3. In the workspace configuration add a section with reference to your meta.yaml
-
    alias: apache-pig-plugin
    type: chePlugin
    reference: https://raw.githubusercontent.com/tolusha/plugins-registry/master/plugins/tolusha/apache-pig-debug/0.0.1/meta.yaml

[1] https://github.com/tolusha/plugins-registry/blob/master/plugins/tolusha/apache-pig-debug/0.0.1/meta.yaml

/cc @tsmaeder

@ericwill
Copy link
Contributor

I completed the following steps:

1. Prepare a docker container with all necessary dependencies. It is a container where your plugin will be run. See the available containers fro Eclipse Che plugins https://github.com/che-dockerfiles/

2. Create a `meta.yaml` file, see my example [1]. Basically you have to define your container and vsix files here.

3. In the workspace configuration add a section with reference to your `meta.yaml`
-
    alias: apache-pig-plugin
    type: chePlugin
    reference: https://raw.githubusercontent.com/tolusha/plugins-registry/master/plugins/tolusha/apache-pig-debug/0.0.1/meta.yaml

[1] https://github.com/tolusha/plugins-registry/blob/master/plugins/tolusha/apache-pig-debug/0.0.1/meta.yaml

This is the way I do it. There is also the option to run a custom plugin registry, but this may be overkill for your use case. This page has some more info.

@l0rd l0rd removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 11, 2020
@leehyeongrak
Copy link
Author

leehyeongrak commented Feb 12, 2020

@tolusha @ericwill
Thanks for the answer.
I tried following the instructions above, but when I modified the Devfile In the workspace configuration and ran the workspace, I faced an "Error: Failed to start the workspace: "Plugin specified by reference URL 'https://github.com/leehyeongrak/plugins-registry/blob/master/plugins/leehyeongrak/jenkins-jack/1.0.0/meta.yaml' have missing required field 'publisher'."" message..

I obviously wrote a publisher in the meta.yaml file like https://github.com/leehyeongrak/plugins-registry/blob/master/plugins/leehyeongrak/jenkins-jack/1.0.0/meta.yaml

The vsix file is in https://github.com/leehyeongrak/vsixes/blob/master/jenkins-jack-1.0.0_vsixhub.com.vsix

And this is the code I wrote in the Devfile

  - type: chePlugin
    reference: >-
      https://github.com/leehyeongrak/plugins-registry/blob/master/plugins/leehyeongrak/jenkins-jack/1.0.0/meta.yaml
    alias: jenkins-plugin

I followed your example, but the results were the same...

What's wrong?

@tolusha
Copy link
Contributor

tolusha commented Feb 12, 2020

@ibuziuk
Copy link
Member

ibuziuk commented Feb 12, 2020

@tolusha @ericwill folks, I believe we need to document this and make it available on the official doc

@leehyeongrak
Copy link
Author

leehyeongrak commented Feb 12, 2020

@tolusha
It works! Thanks for helping me solve the problem!
@ibuziuk
I agree with you, it will be a good guide. I'll cheer you up!

@tolusha tolusha reopened this Feb 12, 2020
@tolusha
Copy link
Contributor

tolusha commented Feb 12, 2020

I've reopened the issue since this information has to be documented.

@tolusha tolusha added the severity/P1 Has a major impact to usage or development of the system. label Feb 12, 2020
@tolusha
Copy link
Contributor

tolusha commented Feb 12, 2020

@ericwill
I marked this issue as P1 since this question arises from time to time

@ibuziuk ibuziuk changed the title How to add VSCode Extension to Eclipse Che? [docs] How to add VSCode Extension to Eclipse Che? Feb 12, 2020
@ericwill
Copy link
Contributor

It can probably be added as part of #14119, which I am working on at the moment.

ericwill added a commit to ericwill/che-docs that referenced this issue Feb 12, 2020
Improve the docs a bit so that it's clear that a meta.yaml file
can be hosted on GitHub, and not just a self-hosted registry link.

See eclipse-che/che#15982

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor

It turns out this process is documented, just not as clearly as it should be. I've opened a PR to fix since it's a relatively straightforward clarification.

ericwill added a commit to ericwill/che-docs that referenced this issue Feb 13, 2020
Improve the docs a bit so that it's clear that a meta.yaml file
can be hosted on GitHub, and not just a self-hosted registry link.

See eclipse-che/che#15982

Signed-off-by: Eric Williams <ericwill@redhat.com>
themr0c pushed a commit to eclipse-che/che-docs that referenced this issue Feb 17, 2020
Improve the docs a bit so that it's clear that a meta.yaml file
can be hosted on GitHub, and not just a self-hosted registry link.

See eclipse-che/che#15982

Signed-off-by: Eric Williams <ericwill@redhat.com>
MichalMaler pushed a commit to MichalMaler/che-docs that referenced this issue Feb 20, 2020
Improve the docs a bit so that it's clear that a meta.yaml file
can be hosted on GitHub, and not just a self-hosted registry link.

See eclipse-che/che#15982

Signed-off-by: Eric Williams <ericwill@redhat.com>
@rkratky
Copy link

rkratky commented Jun 3, 2020

@leehyeongrak, this seems to have been fixed by eclipse-che/che-docs#1074 -- could you please confirm it satisfies your expectations?

@rkratky rkratky removed kind/question Questions that haven't been identified as being feature requests or bugs. severity/P1 Has a major impact to usage or development of the system. labels Jun 3, 2020
@l0rd
Copy link
Contributor

l0rd commented Jul 8, 2020

I think to close this issue we should move the section that explains how to test a vs code extension without adding it to a plugin registry at the top because as mentioned by @ericwill publishing the vscode extension in a plugin registry may be overkill for most of the cases.

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 30, 2020
@benoitf
Copy link
Contributor

benoitf commented Aug 31, 2020

@benoitf benoitf closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation area/plugins status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

8 participants