Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote builtin-related issues on plugins to P1 #16057

Closed
gattytto opened this issue Feb 17, 2020 · 9 comments
Closed

promote builtin-related issues on plugins to P1 #16057

gattytto opened this issue Feb 17, 2020 · 9 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@gattytto
Copy link

as mentioned in the last call
https://docs.google.com/document/d/1duuavOXVAJNbzU8nIltraDKx5YH2Z34Qwx7AeLnhhzU/edit

this issue is to request the P1 priority to issues about new ms-vscode plugins to plug-registry when their implementation requieres a missing (due to being conflicting or unimplemented) builtin in theia.

the process of adding ms-vscode plugins to the plugin registry has been improved a lot and the only blocker I can see so far (that I can't overcome myself by editing the dockerfiles/.vsix sources) is this.

for example:
issue for adding vueJS plugin to che: #13672
the extension gives an error because of the following issue:
eclipse-theia/theia#6623 (comment)

so for conclussion, promoting this issues when the builtin situation arrives would shorten the times in which the users can keep contributing to the new plugins implementations

@gattytto gattytto added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 17, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 17, 2020
@ibuziuk ibuziuk added kind/question Questions that haven't been identified as being feature requests or bugs. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. kind/enhancement A feature request - must adhere to the feature request template. labels Feb 17, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Feb 17, 2020

@gattytto I was not able to attend the last call, so do not know the outcome of the discussion atm. However, the biggest question for me is who is expected to work on those P1s? Does the community members ready to kick on and contribute the missing bits to theia and own the newly contributed plugins?

@tsmaeder
Copy link
Contributor

@gattytto not sure what you mean by "built-in". Do you mean VS Code API or a built-in extension?

@sunix
Copy link
Contributor

sunix commented Feb 18, 2020

@ibuziuk last call @gattytto had a mic problem. We postponed discussion to next monday.

@gattytto
Copy link
Author

gattytto commented Feb 18, 2020

@tsmaeder what I mean with "builtins" is the vs-code built-in extensions as of this: #14759

@ibuziuk what I mean is that there is more complexity to the theia API and builtin extensions so users may encounter known issues with builtins while trying to add a .vsix extension to the plugin registry.

In the case of html-language-features (which is a built-in required by the vuejs extension) it was enough just by adding the html-language-features.vsix prior to the loading of the vuejs extension but there may be cases in which built-ins conflict with each-other or .vsix versions of the ms-vscode builtins are outdated.

So this represents a blocker for a user trying to just make a sidecar container (and maybe a cli one too), and some extension's meta.yaml to add a ms-vscode extension to che. In this case maybe it would be nice to have P1 on this case to get help from che devs around it so users can continue their work

@gattytto
Copy link
Author

@ibuziuk last call @gattytto had a mic problem. We postponed discussion to next monday.

yes I was unable to speak to the mic so I just added the subject to the topics and it was postponed to the next session. Gladly I have fixed my mic problems now and I'll be able to speak with you all next time

@gattytto
Copy link
Author

gattytto commented Mar 11, 2020

this is an example of the situation, the original ms-vscode/vscode-github-pullrequest/latest/meta.yaml has this:

spec:
  extensions:
  - https://github.com/microsoft/vscode-pull-request-github/releases/download/v0.8.0/vscode-pull-request-github-0.8.0.vsix

and changing that for:

spec:
  extensions:
  - https://github.com/microsoft/vscode-pull-request-github/releases/download/0.14.0/vscode-pull-request-github-0.14.0.vsix

as mentioned in the issue, an error about an unimplemented method appears.
#16283

@gattytto
Copy link
Author

gattytto commented Mar 13, 2020

this one is very recent too #16341

@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2020
@ericwill
Copy link
Contributor

ericwill commented Sep 9, 2020

We are working on upgrading all plugins (built-ins and vsix's) to the latest version. Theia API needed for those will be handled on a case by case basis.

I'm going to close this, and we can handle the specific problems in their own issues.

@ericwill ericwill closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

6 participants