Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlens (vs code extension) is not compatible with che due to api not available #16341

Closed
4 of 23 tasks
SDAdham opened this issue Mar 12, 2020 · 0 comments · Fixed by eclipse-che/che-plugin-registry#476
Closed
4 of 23 tasks
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@SDAdham
Copy link

SDAdham commented Mar 12, 2020

Describe the bug

image

Gitlens repo: https://github.com/eamodio/vscode-gitlens

meta.yaml:

apiVersion: v2
publisher: eamodio
name: gitlens
version: 10.2.1
type: VS Code extension
displayName: GitLens
title: GitLens
description: Supercharge the Git capabilities built into Visual Studio Code — Visualize code authorship at a glance via Git blame annotations and code lens, seamlessly navigate and explore Git repositories, gain valuable insights via powerful comparison commands, and so much more
icon: https://github.com/eamodio/vscode-gitlens/blob/master/images/gitlens-icon.png?raw=true
repository: https://github.com/eamodio/vscode-gitlens
category: Other
firstPublicationDate: '2020-03-12'
spec:
  extensions:
    - https://github.com/eamodio/vscode-gitlens/releases/download/v10.2.1/gitlens-10.2.1.vsix

Che version

  • latest
  • nightly
  • other: please specify
    7.9.1

Steps to reproduce

Just put the meta.yaml somewhere and reference the extension to load it in your devfile:

  - reference: 'path/to/v3/plugins/eamodio/gitlens/10.2.1/meta.yaml'
    type: chePlugin

Expected behavior

It should work?

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Eclipse Che Logs

Additional context

@SDAdham SDAdham added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 12, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 12, 2020
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 13, 2020
@ericwill ericwill mentioned this issue May 13, 2020
43 tasks
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue May 26, 2020
* Add vscode-gitlens to the plugin registry

With eclipse-theia/theia#4902 being resolved we can
now use gitlens in Che. The work in Theia is new, so to test you may need
to select theia:next as your editor (instead of latest).

Closes eclipse-che/che#16341

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants