Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode plugin gitlens not support #4902

Closed
502647092 opened this issue Apr 14, 2019 · 7 comments · Fixed by #6921
Closed

vscode plugin gitlens not support #4902

502647092 opened this issue Apr 14, 2019 · 7 comments · Fixed by #6921
Assignees
Labels
bug bugs found in the application scm issues related to the source control manager vscode issues related to VSCode compatibility

Comments

@502647092
Copy link
Contributor

502647092 commented Apr 14, 2019

Description

https://marketplace.visualstudio.com/items?itemName=eamodio.gitlens
not support
image
image

Reproduction Steps

OS and Theia version:
Diagnostics:

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Apr 15, 2019
@akosyakov
Copy link
Member

@502647092 it relies on SCM support and there other missing APIs:

"missingSymbols": [
    "\"vscode\".Clipboard",
    "\"vscode\".Clipboard.writeText",
    "\"vscode\".DecorationInstanceRenderOptions.before",
    "\"vscode\".QuickInput.dispose",
    "\"vscode\".QuickInput.hide",
    "\"vscode\".QuickInput.show",
    "\"vscode\".QuickPick",
    "\"vscode\".QuickPick.busy",
    "\"vscode\".QuickPick.dispose",
    "\"vscode\".QuickPick.enabled",
    "\"vscode\".QuickPick.hide",
    "\"vscode\".QuickPick.ignoreFocusOut",
    "\"vscode\".QuickPick.items",
    "\"vscode\".QuickPick.onDidAccept",
    "\"vscode\".QuickPick.onDidHide",
    "\"vscode\".QuickPick.placeholder",
    "\"vscode\".QuickPick.selectedItems",
    "\"vscode\".QuickPick.show",
    "\"vscode\".QuickPick.title",
    "\"vscode\".QuickPick.value",
    "\"vscode\".Selection.end",
    "\"vscode\".Selection.isEqual",
    "\"vscode\".Selection.isSingleLine",
    "\"vscode\".Selection.start",
    "\"vscode\".SourceControlResourceGroup",
    "\"vscode\".SourceControlResourceGroup.id",
    "\"vscode\".SourceControlResourceGroup.label",
    "\"vscode\".SourceControlResourceGroup.resourceStates",
    "\"vscode\".SourceControlResourceState",
    "\"vscode\".SourceControlResourceState.resourceUri",
    "\"vscode\".ThemeIcon.File",
    "\"vscode\".ThemeIcon.Folder",
    "\"vscode\".TreeItem.description",
    "\"vscode\".TreeView.onDidChangeVisibility",
    "\"vscode\".TreeView.visible",
    "\"vscode\".TreeViewVisibilityChangeEvent",
    "\"vscode\".TreeViewVisibilityChangeEvent.visible",
    "\"vscode\".env.clipboard",
    "\"vscode\".window.createQuickPick"
  ],
  "missingCommands": [
    "editor.action.showReferences",
    "git.pull",
    "gitlens.diffWith",
    "gitlens.openInRemote",
    "openInTerminal",
    "vscode.executeCodeLensProvider",
    "vscode.executeDocumentSymbolProvider",
    "vscode.git",
    "vscode.openFolder",
    "workbench.action.closeActiveEditor",
    "workbench.action.closeAllEditors",
    "workbench.action.nextEditor",
    "workbench.files.action.focusFilesExplorer",
    "workbench.view.explorer"
  ],
  "dynamicCommanCalls": [
    "`${this.id}${location ? `:${location}` : ''}.focus` (/workspace/vscode-gitlens/src/views/viewBase.ts 198:49)",
    "command! (/workspace/vscode-gitlens/src/container.ts 301:57)",
    "command.command (/workspace/vscode-gitlens/src/commands/showLastQuickPick.ts 17:43)",
    "command.command (/workspace/vscode-gitlens/src/views/viewCommands.ts 351:39)",
    "force ? 'git.pushForce' : 'git.push' (/workspace/vscode-gitlens/src/git/models/repository.ts 364:44)",
    "this.command (/workspace/vscode-gitlens/src/quickpicks/commonQuickPicks.ts 93:39)"
  ]

@akosyakov
Copy link
Member

To track progress on SCM support: #4279

@akosyakov akosyakov added bug bugs found in the application scm issues related to the source control manager labels Apr 15, 2019
@alex-gilin
Copy link
Contributor

alex-gilin commented Jun 16, 2019

@akosyakov
Although the mentioned task merged (see above), the 'gitlens' extension does not supported in last available theia version (0.8.0). Whether you plan to put a suitable priority to this issue ?
Thanks.

@502647092
Copy link
Contributor Author

@akosyakov
next version still unable to support gitlens
command vscode.executeDocumentSymbolProvider It seems that it hasn't been implement

editor.main.js:158 Uncaught Error: The command 'vscode.executeDocumentSymbolProvider' cannot be executed. There are no active handlers available for the command. (args: [{"$mid":1,"path":"/home/project/TSWorkSpace/tera/src/core/terahashmining.ts","scheme":"file"}])

Error: The command 'vscode.executeDocumentSymbolProvider' cannot be executed. There are no active handlers available for the command. (args: [{"$mid":1,"path":"/home/project/TSWorkSpace/tera/src/core/terahashmining.ts","scheme":"file"}])
    at e.<anonymous> (command.ts:283)
    at metadata_keys.js:13
    at Object.next (metadata_keys.js:13)
    at a (metadata_keys.js:13)
    at editor.main.js:158
(anonymous) @ editor.main.js:158
setTimeout (async)
unexpectedErrorHandler @ editor.main.js:158
e.onUnexpectedExternalError @ editor.main.js:158
t.onUnexpectedExternalError @ editor.main.js:159
Promise.catch (async)
(anonymous) @ editor.main.js:1345
u @ editor.main.js:1344
(anonymous) @ editor.main.js:1727
u @ editor.main.js:181
(anonymous) @ editor.main.js:1727
e.doRun @ editor.main.js:190
e.onTimeout @ editor.main.js:190
setTimeout (async)
e.schedule @ editor.main.js:190
e._onModelChange @ editor.main.js:1728
e.fire @ editor.main.js:162
e.register @ editor.main.js:922
T @ editor.main.js:2050
e.$registerCodeLensSupport @ languages-main.ts:400
e.doInvokeHandler @ rpc-protocol.ts:249
e.invokeHandler @ rpc-protocol.ts:234
e.receiveRequest @ rpc-protocol.ts:188
e.receiveOneMessage @ rpc-protocol.ts:155
(anonymous) @ rpc-protocol.ts:83
(anonymous) @ rpc-protocol.ts:283
(anonymous) @ event.ts:119
e.invoke @ event.ts:127
e.fire @ event.ts:220
postMessage @ hosted-plugin-watcher.ts:41
(anonymous) @ proxy-factory.ts:160
(anonymous) @ logger-protocol.ts:90
(anonymous) @ logger-protocol.ts:90
(anonymous) @ logger-protocol.ts:90
r @ logger-protocol.ts:90
e.onRequest @ proxy-factory.ts:158
(anonymous) @ proxy-factory.ts:136
(anonymous) @ main.js:361
(anonymous) @ main.js:252
(anonymous) @ main.js:242
(anonymous) @ setImmediate.js:40
f @ setImmediate.js:69
s @ setImmediate.js:109
postMessage (async)
r @ setImmediate.js:120
p.setImmediate @ setImmediate.js:27
H @ main.js:240
W @ main.js:289
t.readMessage @ reader.ts:57
(anonymous) @ reader.ts:18
e.handleMessage @ web-socket-channel.ts:49
n.onmessage @ ws-connection-provider.ts:74

@akosyakov
Copy link
Member

@I051950 we still keep using our native git Theia extension, gitlens cannot work with it. One can though try to remove native and install vscode git extension since it is requirement for gitlens. Maybe it works.

@svenefftinge svenefftinge self-assigned this Oct 7, 2019
svenefftinge added a commit that referenced this issue Oct 7, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 8, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 8, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 8, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 8, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 8, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 8, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Oct 9, 2019
Improves #4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@artalar
Copy link

artalar commented Nov 28, 2019

any updates? 👀

@akosyakov
Copy link
Member

@artalar please give a try, support of many commands, APIs and even webviews was implemented

@akosyakov akosyakov assigned akosyakov and unassigned svenefftinge Jan 20, 2020
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Improves eclipse-theia#4902

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue May 26, 2020
* Add vscode-gitlens to the plugin registry

With eclipse-theia/theia#4902 being resolved we can
now use gitlens in Che. The work in Theia is new, so to test you may need
to select theia:next as your editor (instead of latest).

Closes eclipse-che/che#16341

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants