-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new welcome page every time when I refresh my workspace #16352
Labels
area/plugins
kind/bug
Outline of a bug - must adhere to the bug report template.
severity/P2
Has a minor but important impact to the usage or development of the system.
Milestone
Comments
7 tasks
This was referenced Sep 4, 2020
Closed
To solve this issue need to be merged
|
29 tasks
FYI: Che Theia is already aligned with upstream Theia eclipse-che/che-theia#823 |
16 tasks
This was referenced Sep 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugins
kind/bug
Outline of a bug - must adhere to the bug report template.
severity/P2
Has a minor but important impact to the usage or development of the system.
Describe the bug
Che-Theia always open a new Welcome page when refreshing the workspace.
It looks like the bug is appeared after merging this PR eclipse-che/che-theia#605
I have a strong opinion that we have to revert that branch.
We don't need to store the Welcome page, let the welcome plugin decide whether it should be opened or not (depends on config in preferences).
BTW, on restored welcome page, hyperlinks with commands does not work.
Screencast with the bug https://youtu.be/Ija0oU-i2AY
Che version
Steps to reproduce
Expected behavior
One welcome page with working hyperlinks.
Runtime
minikube version
andkubectl version
)Screenshots
Environment
The text was updated successfully, but these errors were encountered: