Update to the latest Theia #823

azatsarynnyy · 2020-08-03T17:29:34Z

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Updates to the latest Theia.

What issues does this PR fix or reference?

closes eclipse-che/che#17357
closes eclipse-che/che#17550
closes eclipse-che/che#17812
closes eclipse-che/che#16751
probably, should help in solving eclipse-che/che#16352

Depends on

eclipse-che/che#17933

Release Notes

Docs PR

Hapy Path Channel

HAPPY_PATH_CHANNEL=next

RomanNikitenko · 2020-09-23T16:00:50Z

@benoitf
I see some resolutions related logic here. Do you mean this place?

benoitf · 2020-09-23T16:05:14Z

well it would work only in case of Docker build (not for che-theia inside che-theia development)
but let's resolve that later, priority is to merge this PR :)

dmytro-ndp · 2020-09-23T16:23:18Z

[crw-ci-test]

che-bot · 2020-09-23T16:29:14Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:823
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:823

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

RomanNikitenko · 2020-09-23T16:33:34Z

@dmytro-ndp

19:29:10 12:29:09 main [ERRO] stat https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-823/simple/che-theia-editor.yaml: no such file or directory

che-bot · 2020-09-23T16:54:15Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:823
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:823

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

dmytro-ndp · 2020-09-23T17:01:14Z

@RomanNikitenko: please ignore test results #823 (comment) - that was at the middle of Try It buttons links fixup.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

…s language features' Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

RomanNikitenko · 2020-09-24T12:41:15Z

I did the following:

merged Stabilize some happy path tests at update to the latest Theia che#17933
picked up last changes from master branch of che-theia, also it should include dependencies on last changes of theia.

Now I'm waiting on result of happy path tests and going to merge the PR.

benoitf · 2020-09-24T12:49:52Z

cool, lot of commits to handle since August 3 ! 🎉

RomanNikitenko · 2020-09-24T13:00:33Z

Looks like after alignment with current master of theia and che-theia we have a new problem:

 1) TypeScript
       Check Invalid Syntax:
     AssertionError: Timed out retrying: Expected to find content: 'typescripttestTIVgt' within the element: <div#files.p-Widget.theia-Tree.theia-FileTree.theia-Files.ps.p-mod-hidden> but never did.
  AssertionError: Expected to find element: `:not(script,style):cy-contains('typescripttestTIVgt'), [type='submit'][value~='typescripttestTIVgt']`, but never found it.
      at ensureExistence (http://localhost:3100/__cypress/runner/cypress_runner.js:137673:32)
      at Object.ensureElExistence (http://localhost:3100/__cypress/runner/cypress_runner.js:137691:12)
      at ensureExistence (http://localhost:3100/__cypress/runner/cypress_runner.js:127867:23)
      at onFailFn (http://localhost:3100/__cypress/runner/cypress_runner.js:127905:9)
      at tryCatcher (http://localhost:3100/__cypress/runner/cypress_runner.js:9065:23)
      at Promise._settlePromiseFromHandler (http://localhost:3100/__cypress/runner/cypress_runner.js:7000:31)
      at Promise._settlePromise (http://localhost:3100/__cypress/runner/cypress_runner.js:7057:18)
      at Promise._settlePromise0 (http://localhost:3100/__cypress/runner/cypress_runner.js:7102:10)
      at Promise._settlePromises (http://localhost:3100/__cypress/runner/cypress_runner.js:7178:18)
      at _drainQueueStep (http://localhost:3100/__cypress/runner/cypress_runner.js:3772:12)
      at _drainQueue (http://localhost:3100/__cypress/runner/cypress_runner.js:3765:9)
      at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://localhost:3100/__cypress/runner/cypress_runner.js:3781:5)
      at Async.drainQueues (http://localhost:3100/__cypress/runner/cypress_runner.js:3651:14)

Investigating...

che-bot · 2020-09-24T13:14:20Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:823
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:823

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

RomanNikitenko · 2020-09-24T13:53:49Z

Checked locally build of images:

Jobs also look happy after restarting.

* Temporarily remove some plugins where vsix files are missing Part of eclipse-che/che#18933 Signed-off-by: Eric Williams <ericwill@redhat.com> * Update bash-debug location instead of removing Signed-off-by: Eric Williams <ericwill@redhat.com>

RomanNikitenko force-pushed the theia-upgrade branch from 3a5ba59 to 7483bc3 Compare September 1, 2020 07:42

eclipse-che deleted a comment from che-bot Sep 1, 2020

RomanNikitenko force-pushed the theia-upgrade branch 2 times, most recently from 64f412f to 5b6813f Compare September 7, 2020 09:52

eclipse-che deleted a comment from che-bot Sep 7, 2020

eclipse-che deleted a comment from azatsarynnyy Sep 7, 2020

eclipse-che deleted a comment from che-bot Sep 7, 2020

RomanNikitenko force-pushed the theia-upgrade branch from 3038e2d to 8767a5f Compare September 7, 2020 15:08

eclipse-che deleted a comment from che-bot Sep 7, 2020

eclipse-che deleted a comment from che-bot Sep 9, 2020

eclipse-che deleted a comment from che-bot Sep 10, 2020

RomanNikitenko force-pushed the theia-upgrade branch from 606ab0b to ce84b64 Compare September 10, 2020 15:38

eclipse-che deleted a comment from che-bot Sep 10, 2020

This was referenced Sep 11, 2020

Che-theia build fails eclipse-che/che#17812

Closed

Update git extension to 1.44.2 #857

Merged

RomanNikitenko force-pushed the theia-upgrade branch from 921d241 to 7e49ec7 Compare September 14, 2020 07:33

This was referenced Sep 15, 2020

Adapt to new upstream FS API #798

Closed

Editors Sprint 189 eclipse-che/che#17707

Closed

eclipse-che deleted a comment from che-bot Sep 15, 2020

RomanNikitenko mentioned this pull request Sep 16, 2020

[Windows] Building fails for generated che-theia (eclipse-che/theia-generator) eclipse-che/che#17795

Closed

eclipse-che deleted a comment from che-bot Sep 16, 2020

RomanNikitenko force-pushed the theia-upgrade branch from cb0fa9a to f83049f Compare September 16, 2020 08:23

vitaliy-guliy mentioned this pull request Sep 16, 2020

new welcome page every time when I refresh my workspace eclipse-che/che#16352

Closed

5 tasks

azatsarynnyy mentioned this pull request Sep 17, 2020

Editors Sprint 190 eclipse-che/che#17897

Closed

18 tasks

eclipse-che deleted a comment from che-bot Sep 23, 2020

This was referenced Sep 24, 2020

che-theia init should work with commit hashes eclipse-che/che#17940

Open

17481 general preference objects #866

Merged

azatsarynnyy and others added 10 commits September 24, 2020 15:29

Update to the latest Theia

46418cd

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Fix getCurrentWorkspaceUri()

ad33221

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Fix Open workspace problem

c4e46c6

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Use FileService instead of deprecated FileSystem

334b0e5

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Bump eslint related versions

4cd26bb

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Align objects after merging 'testing api for testing vscode extension…

0b5d7bf

…s language features' Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Address Timeline element in Explorer view for cypress tests

cda35f9

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Fix sidecar plugins starting

db2ff2c

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Align CheLanguagesMainTestImpl with Theia objects

90b3f15

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Remove che-theia-filesystem extension

345f463

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

RomanNikitenko force-pushed the theia-upgrade branch from 3cf4687 to 345f463 Compare September 24, 2020 12:31

RomanNikitenko merged commit 680a3ee into master Sep 24, 2020

RomanNikitenko deleted the theia-upgrade branch September 24, 2020 13:54

azatsarynnyy mentioned this pull request Sep 28, 2020

Jupyter Notebooks native support through latest Python VS Code extension eclipse-che/che#16818

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to the latest Theia #823

Update to the latest Theia #823

Uh oh!

azatsarynnyy commented Aug 3, 2020 •

edited by RomanNikitenko

Loading

Uh oh!

RomanNikitenko commented Sep 23, 2020

Uh oh!

benoitf commented Sep 23, 2020

Uh oh!

dmytro-ndp commented Sep 23, 2020

Uh oh!

che-bot commented Sep 23, 2020

Uh oh!

RomanNikitenko commented Sep 23, 2020

Uh oh!

che-bot commented Sep 23, 2020

Uh oh!

dmytro-ndp commented Sep 23, 2020 •

edited

Loading

Uh oh!

RomanNikitenko commented Sep 24, 2020 •

edited

Loading

Uh oh!

benoitf commented Sep 24, 2020

Uh oh!

RomanNikitenko commented Sep 24, 2020

Uh oh!

che-bot commented Sep 24, 2020

Uh oh!

RomanNikitenko commented Sep 24, 2020

Uh oh!

Uh oh!

Update to the latest Theia #823

Update to the latest Theia #823

Uh oh!

Conversation

azatsarynnyy commented Aug 3, 2020 • edited by RomanNikitenko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Depends on

Release Notes

Docs PR

Hapy Path Channel

Uh oh!

RomanNikitenko commented Sep 23, 2020

Uh oh!

benoitf commented Sep 23, 2020

Uh oh!

dmytro-ndp commented Sep 23, 2020

Uh oh!

che-bot commented Sep 23, 2020

Uh oh!

RomanNikitenko commented Sep 23, 2020

Uh oh!

che-bot commented Sep 23, 2020

Uh oh!

dmytro-ndp commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RomanNikitenko commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benoitf commented Sep 24, 2020

Uh oh!

RomanNikitenko commented Sep 24, 2020

Uh oh!

che-bot commented Sep 24, 2020

Uh oh!

RomanNikitenko commented Sep 24, 2020

Uh oh!

Uh oh!

azatsarynnyy commented Aug 3, 2020 •

edited by RomanNikitenko

Loading

dmytro-ndp commented Sep 23, 2020 •

edited

Loading

RomanNikitenko commented Sep 24, 2020 •

edited

Loading