Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che Theia release script should get upstream Theia version from yarn.lock or npmjs.org #16691

Closed
azatsarynnyy opened this issue Apr 21, 2020 · 3 comments · Fixed by eclipse-che/che-theia#737
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Apr 21, 2020

Is your enhancement related to a problem? Please describe.

Currently, Che Theia release script reads upstream Theia version from THEIA_VERSION file that has to be manually updated in master branch before doing a release.
We should avoid this manual update.

Describe the solution you'd like

It can be automated by reading it from yarn.lock file.

Describe alternatives you've considered

It can be automated by reading it from npmjs.org.

Additional context

@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. labels Apr 21, 2020
@vzhukovs vzhukovs added the area/editor/theia Issues related to the che-theia IDE of Che label Apr 21, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Apr 23, 2020
10 tasks
@azatsarynnyy azatsarynnyy self-assigned this Apr 24, 2020
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Apr 24, 2020
@benoitf
Copy link
Contributor

benoitf commented Apr 24, 2020

Hi

I was thinking that it could be nice is that if ./build.sh could

  • by default (or with a flag) grab the current “upstream tag” by looking at npmjs for the next1.1.0-next.669ad8b7 version
  • have a way to specify this version so that we can easily build theia using a previous sha1
  • release mode where we use for example THEIA_VERSION or in that case yarn.lock @theia/core.

so let say someone is blocked with current upstream, he can used a previous tag easily like
./build.sh --upstream-commit-tag 66dd2bc6
and then that we don’t have to provide git-refs stuff, THEIA_VERSION , --branch or git-refs on build.sh script (all being handled)

then make-release would just call build.sh or something different

@benoitf
Copy link
Contributor

benoitf commented Apr 24, 2020

to grab from npmjs:

$ curl --silent http://registry.npmjs.org/-/package/@theia/core/dist-tags | sed 's/.*"next":"\(.*\)".*/\1/'
1.1.0-next.669ad8b7

@azatsarynnyy
Copy link
Member Author

good idea to parametrize upstream version
I'll work on it. Thx!

@azatsarynnyy azatsarynnyy added this to the 7.13 milestone May 6, 2020
@azatsarynnyy azatsarynnyy removed the status/in-progress This issue has been taken by an engineer and is under active development. label May 6, 2020
@azatsarynnyy azatsarynnyy changed the title Che Theia release script should get upstream Theia version from yarn.lock Che Theia release script should get upstream Theia version from yarn.lock or npmjs.org May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants