Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Make it possible to build Che Theia based on upstream Theia commit #737

Merged
merged 2 commits into from
May 6, 2020

Conversation

azatsarynnyy
Copy link
Member

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

With the proposed changes it's possible to build Che Theia based on a particular commit of Theia.

By default, the build works without any changes - it takes the latest commit of Theia in master branch.
THEIA_COMMIT_SHA argument can be passed through the build.sh build-args.

Also, it's not needed anymore to set Theia version to THEIA_VERSION file before doing a release. It will be fetched from npmjs.org.

What issues does this PR fix or reference?

closes eclipse-che/che#16691
closes eclipse-che/che#16654

Release Notes

Docs PR

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented May 5, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:737
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:737

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with build.sh

👍

@benoitf
Copy link
Contributor

benoitf commented May 6, 2020

I'm still wondering about THEIA_COMMIT_SHA, how does it change the yarn.lock dependencies of plug-ins, etc to use that version as well ? looks like it will still try to compile extensions/plugins with yarn.lock settings
it seems it's only managed by release script, not the build script

or should we have as well a parameter like --stick-to-yarn.lock in build.sh to use upstream theia referenced by the one inside the yarn.lock

@azatsarynnyy
Copy link
Member Author

THEIA_COMMIT_SHA doesn't affect node build of the extensions/plugins.
It affects only upstream Theia build with our extensions/plugins included.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants