Do not allow to change webhooks enabled on the fly #16980
Labels
engine/devworkspace
Issues related to Che configured to use the devworkspace controller as workspace engine.
kind/task
Internal things, technical debt, and to-do tasks to be performed.
new¬eworthy
For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
severity/P1
Has a major impact to usage or development of the system.
Is your task related to a problem? Please describe.
Currently, there two aspects that could lead to privileges escalation:
webhooks.enabled: false
and all tokens previously injected into workspaces are not secured anymore.Despite the fact it was handy for local development - it's not safe things to do, so it's proposed to:
Then once operator is removed - it won't be possible to do any exec in any pods (even not related to workspaces since exec subresource does not support labels). So, admin is supposed to make sure that all workspace-related resources are removed and after that manually remove webhooks.
implemented
If an admin really needs to disable webhooks - it's their responsibility to make sure that all workspaces are stopped, remove webhooks and then reconfigure and restart controller.
The text was updated successfully, but these errors were encountered: