Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifests for PR #126 in devworkspace operator #6

Merged

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

Updates manifests for devfile/devworkspace-operator#126. Generated by manually checking out the PR branch in devworkspace-operator and regenerating the files using make gen_terminal_csv.

Do not merged until devfile/devworkspace-operator#126 is merged.

What issues does this PR fix or reference?

related to eclipse-che/che#16967
related to eclipse-che/che#16980

Is it tested? How?

Tested using make build install on crc

Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just so that when the other PR gets merged we can merge this one after

Copy link
Contributor

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed with force the latest changes pulled from devworkspace-operator.
Tested on crc, works as expected - after operator is uninstalled - webhook server still live on the cluster along with webhooks

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk
Copy link
Contributor Author

@sleshchenko Woops, I didn't realize you had already synced the changes. I've pushed probably the same set as you -- I'll double check.

@sleshchenko sleshchenko changed the title [WIP] Update manifests for PR #126 in devworkspace operator Update manifests for PR #126 in devworkspace operator Jul 14, 2020
@sleshchenko
Copy link
Contributor

@sleshchenko Woops, I didn't realize you had already synced the changes. I've pushed probably the same set as you -- I'll double check.

Np. Force push is a devil but we love using it so much :-D
Checked that no files are changed after make gen_terminal_csv

@sleshchenko sleshchenko merged commit af3e363 into redhat-developer:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants