-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend plugin meta model to include health check endpoint #17002
Comments
I believe we have similar issues on Hosted Che when for example theia route is not yet available - redhat-developer/rh-che#1657 / #17542 |
@ericwill I put P1, but feel free to update the priority based on the team priorities |
Not sure which area this one actually falls under -- there's a plugin side change somewhere, but the plugin spec changes would mostly be handled by infra/plugin broker. @ibuziuk @ericwill WDYT about:
|
Is it something that should be addressed in Devfile 2.x format? @l0rd @davidfestal WDYT? |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
I think this issue should just be closed; likely this functionality, if useful, would be implemented in devfile 2.0 |
Is your enhancement related to a problem? Please describe.
One of the steps in workspace startup is waiting for any servers to be ready. It would be convenient if plugin specs could define an endpoint which can be pinged to check for server readiness/health.
Describe the solution you'd like
Add health check endpoints to plugin meta model. Potentially a liveness and readiness definition, parallel to what exists in Kubernetes.
Describe alternatives you've considered
Rely on communicating with a port defined for the plugin.
Additional context
The Che workspace operator needs to be able to check for server readiness before marking a workspace as 'Running', to avoid 503 errors. See PR devfile/devworkspace-operator#78 for details.
The text was updated successfully, but these errors were encountered: