Check servers health before setting status to running #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check /healthz endpoint on Signed-off-by: Angel Misevski <amisevsk@redhat.com>
sleshchenko
approved these changes
May 22, 2020
| @@ -18,7 +18,6 @@ spec: | |||
| attributes: | |||
| protocol: http | |||
| type: ide | |||
| path: /static/ | |||
There was a problem hiding this comment.
wonder if we keep web app on that endpoint... Then probably healthz endpoint should be defined as a separate configuration for endpoint I suppose.
So, please consider creating an issue to extend plugin meta model with health checks.
There was a problem hiding this comment.
Created eclipse-che/che#17002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds polling to
${ideUrl}/healthzand doesn't setRunningphase for workspace until endpoint is responding.Expects a 2xx response, but will proceed on a 404 for compatibility.
What issues does this PR fix or reference?
503 errors in OpenShift Terminal
Is it tested? How?
Depends on eclipse-che/che-machine-exec#105 ideally. Image is built and available at
docker.io/amisevsk/che-machine-exec:dev, which you can use in the internal registry for testing.Tested on
crcwith updated image and with default image that doesn't have/healthzendpoint.On my local
crc, I typically see 2-3 seconds of503errors before getting a200