Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin-registry PR check to validate new/updated vsx #17027

Closed
l0rd opened this issue May 27, 2020 · 1 comment
Closed

Add plugin-registry PR check to validate new/updated vsx #17027

l0rd opened this issue May 27, 2020 · 1 comment
Assignees
@ericwill
Labels
area/plugin-registry area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.x (Later, Futur...

Comments

@l0rd
Copy link
Contributor

l0rd commented May 27, 2020 •
edited
Loading

Is your enhancement related to a problem? Please describe.

We do not have an automated check that validates a vs code extension in the plugin-registry

Describe the solution you'd like

We should have a PR check (gh action) that does some basic checks on any new or updated meta.yaml:

  • URLs in the meta.yaml are not broken: repository, icon, extensions
  • Images in the containers section of the meta.yaml exist
  • Extension can be started successfully in its sidecar container (or in nightly che-theia container)

Tests should be run ONLY if the PR includes the creation of a new meta.yaml file (for a new extension or for a new version of an existing extension).

Additional context

The plugin registry has already a PR check that currently verifies that the happy path test workspace starts and e2e test flow doesn't get broken. This issue instead is about running a functional test (not e2e) for new or updated extensions.

Included in epic #15819
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label May 27, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 27, 2020
@l0rd l0rd changed the title Add plugin-registry PR check to validate new/updated vs code extensions Add plugin-registry PR check to validate new/updated vsx May 27, 2020
@mmorhun mmorhun added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 27, 2020
This was referenced May 27, 2020
Closed
Closed
Closed
@ericwill ericwill mentioned this issue May 27, 2020
Closed
2 tasks
@ericwill ericwill mentioned this issue Aug 20, 2020
Closed
32 tasks
@ericwill ericwill mentioned this issue Sep 10, 2020
Closed
29 tasks
@ericwill ericwill self-assigned this Sep 18, 2020
@ericwill ericwill added this to the 7.x (Later, Future, Never) milestone Sep 18, 2020
@ericwill ericwill mentioned this issue Sep 22, 2020
Merged
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Sep 23, 2020
@ericwill
PR check for vscode-extensions.json fields (#625)
2811372 
Checks:
* extension git repo is cloneable
* revision field for the extension's git repo is valid
* sidecar git repo is cloneable

See eclipse-che/che#17027

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor

This has been done now that we have generated meta.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwill ericwill

Labels
area/plugin-registry area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.x (Later, Future, Never)
Development

No branches or pull requests
4 participants
@l0rd @ericwill @mmorhun @che-bot