Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openshift Connector plugin tries to authenticate via oAuth when it is not enabled. #17633

Closed
5 of 22 tasks
vinokurig opened this issue Aug 13, 2020 · 1 comment
Closed
5 of 22 tasks

Openshift Connector plugin tries to authenticate via oAuth when it is not enabled. #17633

vinokurig opened this issue Aug 13, 2020 · 1 comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.18

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Aug 13, 2020 •
edited
Loading

Describe the bug

Openshift Connector plugin tries to authenticate via openshift oAuth when it is not enabled.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Deploy Che without --os-oauth flag
  2. Start a workspace with the Openshift connector plugin.
  3. When the workspace starts the authentication plugin is not interrupted:
    screenshot-che-che apps che devcluster openshift com-2020 08 13-15_54_38

Expected behavior

The authentication plugin must be stopped, if the openshift oauth is disabled.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Eclipse Che Logs

Additional context
@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins area/plugins labels Aug 13, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 13, 2020
@ericwill ericwill added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 13, 2020
ericwill added a commit to ericwill/che-sidecar-openshift-connector that referenced this issue Aug 13, 2020
@ericwill
Fix missing oc tool, use curl instead of wget
5102898 
See eclipse-che/che#17633

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Aug 13, 2020
Merged
@ericwill ericwill added this to the 7.18 milestone Aug 13, 2020
@ericwill ericwill mentioned this issue Aug 13, 2020
Closed
29 tasks
ericwill added a commit to che-dockerfiles/che-sidecar-openshift-connector that referenced this issue Aug 13, 2020
@ericwill
Fix missing oc tool, use curl instead of wget (#17)
620dbc7 
See eclipse-che/che#17633

Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill mentioned this issue Aug 13, 2020
Merged
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue Aug 17, 2020
@ericwill
Update vscode-openshift-connector sidecar image (#571)
892db33 
New image has:
* Removed wget, used curl instead
* Fixed issue with oc missing from the container

See eclipse-che/che#17633

Signed-off-by: Eric Williams <ericwill@redhat.com>
@vinokurig
Copy link
Contributor Author

Is fixed by eclipse-che/che-plugin-registry#571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.18
Development

No branches or pull requests
3 participants
@ericwill @vinokurig @che-bot