-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up release for Dashboard Next #17647
Comments
@l0rd @nickboldt @mkuznyetsov WDYT? |
about about tags like |
@sunix What the motivation to use next? next seems to indicate that it's rolling tag, but not release... |
the problem with renaming the image name is that it will be hard to maintain: it is a new version of the dashboard and not anything else, not a new project. It will replace the current dashboard in the near futur. To me it sounds very confusing. If at some point we switch If you could keep the image name, it would be simpler and more consistent for the futur. There is nothing in In the maven world, we have something called 'Qualifier' for these kind of things |
@sunix Thanks for sharing your thoughts!
|
Update: to avoid confusion with next word in two meanings (one is dashboard next, another is next changes from main branch), we agreed to the following tags: |
So for Che 7.23, you're asking that:
This is a problem for me since CRW 2.6 will be based on Che 7.24, and it seems like Dashboard Next isn't quite ready for product inclusion.
Can we disable it in CRW 2.6? |
That's already done in https://github.com/che-incubator/che-dashboard-next/blob/master/.github/workflows/dockerimage.yml
I assumed it's not an issue for CRW since it has its own Dockerfile that can still be with the existing dashboard only.
Yes, it's what we're asking. Tomorrow we'll discuss the promotion of the Dashboard Next. As I've had announced on Che Community Call, on 7.25 we're going to replace Dashboard with Dashboard Next. But we still need to make a clear plan if we should promote it into CRW 2.7 or 2.8, hopefully not later. |
ah, ok, if it's for 7.25 I'm less worried. :) Is the plan to merge https://github.com/che-incubator/che-dashboard-next into the che-dashboard repo? If so, is that happening in 7.25, too? Note that the internal call is Wed this week due to demos. |
I planned to do it, like the existing dashboard could be moved to the legacy branch, and the dashboard next can start live in a new default branch called |
There is nothing to do, React-based Dashboard will get release process set up once it's moved to master branch https://github.com/eclipse/che-dashboard/tree/main-react/.github since it reuses the same build procedure we can just use the same release github action. |
Is your task related to a problem? Please describe.
Currently, Dashboard Next is packaged into Che from next dockerimage image that we have at Che release time.
It was chosen as an easier way to go: the release of dashboard next is not really mandatory since we don't have fully complete basic workflows (it's kind of alpha phase).
It has a drawback because if we want to check which dashboard next snapshot is included into Che release - we need to figure out which image is included, find the corresponding commit in the Dashboard Next repo and then analyze history somehow.
It would be much easier if we start releasing Dashboard Next, technically it's pretty easy to implement but we need to agree on some aspects:
The text was updated successfully, but these errors were encountered: